From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiKUl-00016y-8U for qemu-devel@nongnu.org; Sun, 04 Feb 2018 08:38:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiKUg-0005GN-Il for qemu-devel@nongnu.org; Sun, 04 Feb 2018 08:38:11 -0500 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:37852) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eiKUg-0005Dt-C6 for qemu-devel@nongnu.org; Sun, 04 Feb 2018 08:38:06 -0500 Received: by mail-wr0-x244.google.com with SMTP id a43so19366131wrc.4 for ; Sun, 04 Feb 2018 05:38:05 -0800 (PST) References: <20180204064911.9828-1-richard.henderson@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20180204064911.9828-1-richard.henderson@linaro.org> Date: Sun, 04 Feb 2018 13:38:03 +0000 Message-ID: <87k1vszxhg.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] hw/hppa: Use qemu_log_mask instead of fprintf to stderr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org Richard Henderson writes: > Reported-by: Thomas Huth > Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e > --- > hw/hppa/machine.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c > index afd3867313..19033e268d 100644 > --- a/hw/hppa/machine.c > +++ b/hw/hppa/machine.c > @@ -19,6 +19,7 @@ > #include "hw/hppa/hppa_sys.h" > #include "qemu/cutils.h" > #include "qapi/error.h" > +#include "qemu/log.h" > > #define MAX_IDE_BUS 2 > > @@ -111,7 +112,6 @@ static void machine_hppa_init(MachineState *machine) > uint32_t addr =3D DINO_UART_HPA + 0x800; > serial_mm_init(addr_space, addr, 0, serial_irq, > 115200, serial_hds[0], DEVICE_BIG_ENDIAN); > - fprintf(stderr, "Serial port created at 0x%x\n", addr); > } > > /* SCSI disk setup. */ > @@ -146,9 +146,9 @@ static void machine_hppa_init(MachineState *machine) > error_report("could not load firmware '%s'", firmware_filename); > exit(1); > } > - fprintf(stderr, "Firmware loaded at 0x%08" PRIx64 "-0x%08" PRIx64 > - ", entry at 0x%08" PRIx64 ".\n", > - firmware_low, firmware_high, firmware_entry); > + qemu_log_mask(CPU_LOG_PAGE, "Firmware loaded at 0x%08" PRIx64 > + "-0x%08" PRIx64 ", entry at 0x%08" PRIx64 ".\n", > + firmware_low, firmware_high, firmware_entry); > if (firmware_low < ram_size || firmware_high >=3D FIRMWARE_END) { > error_report("Firmware overlaps with memory or IO space"); > exit(1); > @@ -163,7 +163,6 @@ static void machine_hppa_init(MachineState *machine) > > /* Load kernel */ > if (kernel_filename) { > - fprintf(stderr, "LOADING kernel '%s'\n", kernel_filename); > size =3D load_elf(kernel_filename, &cpu_hppa_to_phys, > NULL, &kernel_entry, &kernel_low, &kernel_high, > true, EM_PARISC, 0, 0); > @@ -177,10 +176,10 @@ static void machine_hppa_init(MachineState *machine) > error_report("could not load kernel '%s'", kernel_filename); > exit(1); > } > - > - fprintf(stderr, "Kernel loaded at 0x%08" PRIx64 "-0x%08" PRIx64 > - ", entry at 0x%08" PRIx64 ", size %ld kB.\n", > - kernel_low, kernel_high, kernel_entry, size / 1024); > + qemu_log_mask(CPU_LOG_PAGE, "Kernel loaded at 0x%08" PRIx64 > + "-0x%08" PRIx64 ", entry at 0x%08" PRIx64 > + ", size %ld kB.\n", > + kernel_low, kernel_high, kernel_entry, size / 1024= ); > > if (kernel_cmdline) { > cpu[0]->env.gr[24] =3D 0x4000; -- Alex Benn=C3=A9e