From: "Alex Bennée" <alex.bennee@linaro.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
KONRAD Frederic <fred.konrad@greensocs.com>,
"Emilio G. Cota" <cota@braap.org>,
Richard Henderson <rth@twiddle.net>,
Pranith Kumar <bobby.prani@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] qemu-2.9 crashes in tcg_handle_interrupt() during winx64 boot
Date: Thu, 30 Mar 2017 16:05:58 +0100 [thread overview]
Message-ID: <87k2764xex.fsf@linaro.org> (raw)
In-Reply-To: <20170330164657.50c75e8c@nial.brq.redhat.com>
Igor Mammedov <imammedo@redhat.com> writes:
> (PS: resend due to wrong qemu-devel mail list address in original
> email)
Le *sigh* another way of x86 generating IRQs ;-)
Could you test this please?
target/i386/misc_helper: wrap BQL around another IRQ generator
Anything that calls into HW emulation must be protected by the BQL.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
1 file changed, 2 insertions(+)
target/i386/misc_helper.c | 2 ++
modified target/i386/misc_helper.c
@@ -156,7 +156,9 @@ void helper_write_crN(CPUX86State *env, int reg, target_ulong t0)
break;
case 8:
if (!(env->hflags2 & HF2_VINTR_MASK)) {
+ qemu_mutex_lock_iothread();
cpu_set_apic_tpr(x86_env_get_cpu(env)->apic_state, t0);
+ qemu_mutex_unlock_iothread();
}
env->v_tpr = t0 & 0x0f;
break;
--
Alex Bennée
next prev parent reply other threads:[~2017-03-30 15:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 14:46 [Qemu-devel] qemu-2.9 crashes in tcg_handle_interrupt() during winx64 boot Igor Mammedov
2017-03-30 15:05 ` Alex Bennée [this message]
2017-03-30 16:14 ` Alex Bennée
2017-03-31 8:21 ` Igor Mammedov
2017-03-31 8:58 ` Alex Bennée
2017-03-31 12:08 ` Paolo Bonzini
2017-04-05 12:51 ` Igor Mammedov
2017-04-05 13:26 ` Alex Bennée
2017-04-05 16:03 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2764xex.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=bobby.prani@gmail.com \
--cc=cota@braap.org \
--cc=fred.konrad@greensocs.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).