Re: [Qemu-devel] [PATCH 10/22] fsdev: break out 9p-marshal.{c, h} from virtio-9p-marshal.{c, h}

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

Wei Liu <wei.liu2@citrix.com> writes:

> Break out some generic functions for marshaling 9p state. Pure code
> motion plus minor fixes for build system.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  Makefile                  |  2 +-
>  fsdev/9p-marshal.c        | 57 ++++++++++++++++++++++++++++++++
>  fsdev/9p-marshal.h        | 84 +++++++++++++++++++++++++++++++++++++++++++++++
>  fsdev/Makefile.objs       |  2 +-
>  fsdev/virtio-9p-marshal.c | 31 -----------------
>  fsdev/virtio-9p-marshal.h | 79 +-------------------------------------------
>  6 files changed, 144 insertions(+), 111 deletions(-)
>  create mode 100644 fsdev/9p-marshal.c
>  create mode 100644 fsdev/9p-marshal.h
>
> diff --git a/Makefile b/Makefile
> index 82b2fc8..7e881d8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -240,7 +240,7 @@ qemu-io$(EXESUF): qemu-io.o $(block-obj-y) $(crypto-obj-y) $(qom-obj-y) libqemuu
>
>  qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o
>
> -fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/virtio-9p-marshal.o libqemuutil.a libqemustub.a
> +fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/9p-marshal.o fsdev/virtio-9p-marshal.o libqemuutil.a libqemustub.a
>  fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap
>
>  qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx
> diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c
> new file mode 100644
> index 0000000..610978e
> --- /dev/null
> +++ b/fsdev/9p-marshal.c
> @@ -0,0 +1,57 @@
> +/*
> + * 9p backend
> + *
> + * Copyright IBM, Corp. 2010
> + *
> + * Authors:
> + *  Anthony Liguori   <aliguori@us.ibm.com>
> + *  Wei Liu <wei.liu2@citrix.com>


If it is just code movement just retain the authors as it is ?

> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + *
> + */
> +

-aneesh