From: Juan Quintela <quintela@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: amit.shah@redhat.com, peter.huangpeng@huawei.com,
qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: Add state records for migration incoming
Date: Wed, 18 Nov 2015 11:51:51 +0100 [thread overview]
Message-ID: <87k2pfpol4.fsf@emacs.mitica> (raw)
In-Reply-To: <1445503751-19912-1-git-send-email-zhang.zhanghailiang@huawei.com> (zhanghailiang's message of "Thu, 22 Oct 2015 16:49:11 +0800")
zhanghailiang <zhang.zhanghailiang@huawei.com> wrote:
> For migration destination, sometimes we need to know its state,
> and it is also useful for tracing migration incoming process.
>
> Here we add a new member 'state' for MigrationIncomingState,
> and also use migrate_set_state() to modify its value.
> We fix the first parameter of migrate_set_state(), and make it
> public.
>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
1st: split the patch about the change in migrate_set_state prototype,
and the rest.
Once there, if we are going to do this, at least show it on info migrate
on destination?
If we are going this way, I think it is going to be better to reuse
MigrationState? That way, we could make the info migrate statistics
easier to understand?
Thanks, Juan.
next prev parent reply other threads:[~2015-11-18 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 8:49 [Qemu-devel] [PATCH] migration: Add state records for migration incoming zhanghailiang
2015-11-18 10:51 ` Juan Quintela [this message]
2015-11-24 3:05 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2pfpol4.fsf@emacs.mitica \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).