From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz0LT-0003QI-Vf for qemu-devel@nongnu.org; Wed, 18 Nov 2015 05:52:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz0LP-0008D9-5H for qemu-devel@nongnu.org; Wed, 18 Nov 2015 05:52:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz0LO-0008Cz-W6 for qemu-devel@nongnu.org; Wed, 18 Nov 2015 05:52:07 -0500 From: Juan Quintela In-Reply-To: <1445503751-19912-1-git-send-email-zhang.zhanghailiang@huawei.com> (zhanghailiang's message of "Thu, 22 Oct 2015 16:49:11 +0800") References: <1445503751-19912-1-git-send-email-zhang.zhanghailiang@huawei.com> Date: Wed, 18 Nov 2015 11:51:51 +0100 Message-ID: <87k2pfpol4.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] migration: Add state records for migration incoming Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: amit.shah@redhat.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, dgilbert@redhat.com zhanghailiang wrote: > For migration destination, sometimes we need to know its state, > and it is also useful for tracing migration incoming process. > > Here we add a new member 'state' for MigrationIncomingState, > and also use migrate_set_state() to modify its value. > We fix the first parameter of migrate_set_state(), and make it > public. > > Signed-off-by: zhanghailiang > Reviewed-by: Dr. David Alan Gilbert 1st: split the patch about the change in migrate_set_state prototype, and the rest. Once there, if we are going to do this, at least show it on info migrate on destination? If we are going this way, I think it is going to be better to reuse MigrationState? That way, we could make the info migrate statistics easier to understand? Thanks, Juan.