From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: qemu-trivial@nongnu.org,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
qemu-devel@nongnu.org, proljc@gmail.com
Subject: Re: [Qemu-devel] [PATCH] openrisc: cpu: Remove unused cpu_get_pc
Date: Thu, 30 Apr 2015 09:37:17 +0100 [thread overview]
Message-ID: <87k2wu1076.fsf@linaro.org> (raw)
In-Reply-To: <1430379532-7300-1-git-send-email-crosthwaite.peter@gmail.com>
Peter Crosthwaite <crosthwaitepeter@gmail.com> writes:
> This function is not used by anything. Remove.
>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> target-openrisc/cpu.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/target-openrisc/cpu.h b/target-openrisc/cpu.h
> index b25324b..9e23cd0 100644
> --- a/target-openrisc/cpu.h
> +++ b/target-openrisc/cpu.h
> @@ -415,9 +415,4 @@ static inline int cpu_mmu_index(CPUOpenRISCState *env)
>
> #include "exec/exec-all.h"
>
> -static inline target_ulong cpu_get_pc(CPUOpenRISCState *env)
> -{
> - return env->pc;
> -}
> -
> #endif /* CPU_OPENRISC_H */
Are you going to clean up the the microblaze one as well?
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
prev parent reply other threads:[~2015-04-30 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 7:38 [Qemu-devel] [PATCH] openrisc: cpu: Remove unused cpu_get_pc Peter Crosthwaite
2015-04-30 8:37 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2wu1076.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).