From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56201)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1Ynjxd-0003RD-93
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 04:36:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1Ynjxc-0001P9-Aw
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 04:36:45 -0400
References: <1430379532-7300-1-git-send-email-crosthwaite.peter@gmail.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1430379532-7300-1-git-send-email-crosthwaite.peter@gmail.com>
Date: Thu, 30 Apr 2015 09:37:17 +0100
Message-ID: <87k2wu1076.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] openrisc: cpu: Remove unused cpu_get_pc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: qemu-trivial@nongnu.org, Peter Crosthwaite <crosthwaite.peter@gmail.com>, qemu-devel@nongnu.org, proljc@gmail.com


Peter Crosthwaite <crosthwaitepeter@gmail.com> writes:

> This function is not used by anything. Remove.
>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
>  target-openrisc/cpu.h | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/target-openrisc/cpu.h b/target-openrisc/cpu.h
> index b25324b..9e23cd0 100644
> --- a/target-openrisc/cpu.h
> +++ b/target-openrisc/cpu.h
> @@ -415,9 +415,4 @@ static inline int cpu_mmu_index(CPUOpenRISCState *env)
>  
>  #include "exec/exec-all.h"
>  
> -static inline target_ulong cpu_get_pc(CPUOpenRISCState *env)
> -{
> -    return env->pc;
> -}
> -
>  #endif /* CPU_OPENRISC_H */

Are you going to clean up the the microblaze one as well?

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée