From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXUiq-0001fc-7d for qemu-devel@nongnu.org; Mon, 16 Mar 2015 09:06:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXUim-0005os-Pp for qemu-devel@nongnu.org; Mon, 16 Mar 2015 09:06:19 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:33950 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXUim-0005oo-Jn for qemu-devel@nongnu.org; Mon, 16 Mar 2015 09:06:16 -0400 References: <1426509364-19513-1-git-send-email-berrange@redhat.com> <1426509364-19513-3-git-send-email-berrange@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1426509364-19513-3-git-send-email-berrange@redhat.com> Date: Mon, 16 Mar 2015 13:06:33 +0000 Message-ID: <87k2yhay7a.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/3] ui: replace printf() calls with VNC_DEBUG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Gerd Hoffmann Daniel P. Berrange writes: > Handling of VNC audio messages results in printfs to the console. > This is of no use to anyone in production, so should be using the > normal VNC_DEBUG macro instead. > > Signed-off-by: Daniel P. Berrange Reviewed-by: Alex Bennée > --- > ui/vnc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/ui/vnc.c b/ui/vnc.c > index 6f9b718..80dc63b 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -2400,34 +2400,34 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len) > case 4: vs->as.fmt = AUD_FMT_U32; break; > case 5: vs->as.fmt = AUD_FMT_S32; break; > default: > - printf("Invalid audio format %d\n", read_u8(data, 4)); > + VNC_DEBUG("Invalid audio format %d\n", read_u8(data, 4)); > vnc_client_error(vs); > break; > } > vs->as.nchannels = read_u8(data, 5); > if (vs->as.nchannels != 1 && vs->as.nchannels != 2) { > - printf("Invalid audio channel coount %d\n", > - read_u8(data, 5)); > + VNC_DEBUG("Invalid audio channel coount %d\n", > + read_u8(data, 5)); > vnc_client_error(vs); > break; > } > vs->as.freq = read_u32(data, 6); > break; > default: > - printf ("Invalid audio message %d\n", read_u8(data, 4)); > + VNC_DEBUG("Invalid audio message %d\n", read_u8(data, 4)); > vnc_client_error(vs); > break; > } > break; > > default: > - printf("Msg: %d\n", read_u16(data, 0)); > + VNC_DEBUG("Msg: %d\n", read_u16(data, 0)); > vnc_client_error(vs); > break; > } > break; > default: > - printf("Msg: %d\n", data[0]); > + VNC_DEBUG("Msg: %d\n", data[0]); > vnc_client_error(vs); > break; > } -- Alex Bennée