From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36825)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WiSJd-0003RC-6P
	for qemu-devel@nongnu.org; Thu, 08 May 2014 13:41:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WiSJW-0007Fs-5r
	for qemu-devel@nongnu.org; Thu, 08 May 2014 13:41:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38751)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WiSJV-0007Fo-Ue
	for qemu-devel@nongnu.org; Thu, 08 May 2014 13:40:58 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <CAFEAcA-A8OpAQZJG9ufF9jSwSLs1Oxz8R9ca5WOG5+6GRPfdmw@mail.gmail.com>
	(Peter Maydell's message of "Thu, 8 May 2014 13:01:41 +0100")
References: <1398091304-10677-1-git-send-email-quintela@redhat.com>
	<1398091304-10677-5-git-send-email-quintela@redhat.com>
	<CAFEAcA-4BAB_G3+rBp1u4CtZCCV0=b2xeuxQTc2yDxNxSo=8Mw@mail.gmail.com>
	<CAFEAcA-A8OpAQZJG9ufF9jSwSLs1Oxz8R9ca5WOG5+6GRPfdmw@mail.gmail.com>
Date: Thu, 08 May 2014 19:40:53 +0200
Message-ID: <87k39w184a.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded
	version_minimum_id_old (arm)
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Peter Maydell <peter.maydell@linaro.org> wrote:
> On 21 April 2014 17:18, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 21 April 2014 15:39, Juan Quintela <quintela@redhat.com> wrote:
>>> After previous Peter patch, they are redundant.  This way we don't asign them
>>> except when needed.  Once there, there were lots of case where the ".fields"
>>> indentation was wrong:
>>>
>>>      .fields = (VMStateField []) {
>>> and
>>>      .fields =      (VMStateField []) {
>>>
>>> Change all the combinations to:
>>>
>>>      .fields = (VMStateField[]){
>>>
>>> The biggest problem (appart of aesthetics) was that checkpatch complained
>>> when we copy&pasted the code from one place to another.
>>>
>>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>>> ---
>>
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> I'll hold this to apply to target-arm.next when you've got the dependent
>> patch into master.
>
> The dependent patch is now in master so I'm going to include this
> in the target-arm queue (with the various typos Eric pointed out
> in the commit message fixed).

I have it on mine.  And the "rest" part was also reviewed-by.

I can include it on my next pull request, or do it yourself, whatever is
easier for you.

Later, Juan.