From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTarr-0005Oh-Q2 for qemu-devel@nongnu.org; Fri, 28 Mar 2014 13:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTarm-0000Un-RE for qemu-devel@nongnu.org; Fri, 28 Mar 2014 13:46:59 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:33642 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTarm-0000UL-Ls for qemu-devel@nongnu.org; Fri, 28 Mar 2014 13:46:54 -0400 References: <1396025007-27592-1-git-send-email-alex.bennee@linaro.org> <1396025007-27592-8-git-send-email-alex.bennee@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Fri, 28 Mar 2014 17:47:18 +0000 Message-ID: <87k3beb4gp.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 7/7] qemu-log: add nochain option to disable TB chaining List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers Peter Maydell writes: > On 28 March 2014 16:43, Alex Bennée wrote: >> The current exec and cpu flags only show information when we enter a >> TranslationBlock. The blocks will then chain together until there is a >> reason to exit which can make things harder to follow. This new option >> disables the chaining for debugging purposes. >> >> + { CPU_LOG_TB_NOCHAIN, "nochain", >> + "disable chaining of translation blocks (better tracing, but slower)" }, > > I know it's a convenient place to put it, but it's not really > a tracing option so I'm a bit dubious about putting it in > the log flags... Yeah I know, but I didn't really want to make a new tcg opts set of flags as it's more of logging clarity kinda option. Of course this glosses over the fact it is also useful for tcg trace-events (when I send them). Is it time to expose a set of TCG fiddling variables? > > thanks > -- PMM -- Alex Bennée