From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] Fix vmstate_info_int32_le comparison/assign
Date: Wed, 12 Feb 2014 18:08:21 +0100 [thread overview]
Message-ID: <87k3d09s3e.fsf@elfo.mitica> (raw)
In-Reply-To: <1392221537-29430-1-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Wed, 12 Feb 2014 16:12:17 +0000")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Fix comparison of vmstate_info_int32_le so that it succeeds if loaded
> value is (l)ess than or (e)qual
>
> When the comparison succeeds, assign the value loaded
> This is a change in behaviour but I think the original intent, since
> the idea is to check if the version/size of the thing you're loading is
> less than some limit, but you might well want to do something based on
> the actual version/size in the file
>
> Fix up comment and name text
> ---
> vmstate.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
Reviewed-by: Juan Quintela <quintela@redhat.com>
And as I am the author, brown paper bag for me.
prev parent reply other threads:[~2014-02-12 17:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 16:12 [Qemu-devel] [PATCH 1/1] Fix vmstate_info_int32_le comparison/assign Dr. David Alan Gilbert (git)
2014-02-12 17:08 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3d09s3e.fsf@elfo.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).