From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDdIW-000498-5p for qemu-devel@nongnu.org; Wed, 12 Feb 2014 12:08:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDdIQ-0007ap-78 for qemu-devel@nongnu.org; Wed, 12 Feb 2014 12:08:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDdIQ-0007aj-02 for qemu-devel@nongnu.org; Wed, 12 Feb 2014 12:08:26 -0500 From: Juan Quintela In-Reply-To: <1392221537-29430-1-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Wed, 12 Feb 2014 16:12:17 +0000") References: <1392221537-29430-1-git-send-email-dgilbert@redhat.com> Date: Wed, 12 Feb 2014 18:08:21 +0100 Message-ID: <87k3d09s3e.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 1/1] Fix vmstate_info_int32_le comparison/assign Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Fix comparison of vmstate_info_int32_le so that it succeeds if loaded > value is (l)ess than or (e)qual > > When the comparison succeeds, assign the value loaded > This is a change in behaviour but I think the original intent, since > the idea is to check if the version/size of the thing you're loading is > less than some limit, but you might well want to do something based on > the actual version/size in the file > > Fix up comment and name text > --- > vmstate.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) Reviewed-by: Juan Quintela And as I am the author, brown paper bag for me.