From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9zoq-0002qU-J6 for qemu-devel@nongnu.org; Sun, 02 Feb 2014 11:24:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W9znJ-0000SD-FV for qemu-devel@nongnu.org; Sun, 02 Feb 2014 11:22:52 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:58791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9znI-0000Ry-P5 for qemu-devel@nongnu.org; Sun, 02 Feb 2014 11:21:17 -0500 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Feb 2014 02:21:13 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 0AA0B3578052 for ; Mon, 3 Feb 2014 03:21:10 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s12GKvcg54460638 for ; Mon, 3 Feb 2014 03:20:57 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s12GL9hV005280 for ; Mon, 3 Feb 2014 03:21:09 +1100 From: "Aneesh Kumar K.V" In-Reply-To: <1390921707-15109-2-git-send-email-kirill.shutemov@linux.intel.com> References: <1390921707-15109-1-git-send-email-kirill.shutemov@linux.intel.com> <1390921707-15109-2-git-send-email-kirill.shutemov@linux.intel.com> Date: Sun, 02 Feb 2014 21:50:56 +0530 Message-ID: <87k3dd4hav.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/4] hw/9pfs: handle undefined FS_IOC_GETVERSION case in handle_ioc_getversion() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Kirill A. Shutemov" , qemu-devel@nongnu.org, aliguori@amazon.com, mst@redhat.com Cc: armbru@redhat.com "Kirill A. Shutemov" writes: > All get_st_gen() implementations except handle_ioc_getversion() have > guard for undefined FS_IOC_GETVERSION. Let's add it there too. > > Signed-off-by: Kirill A. Shutemov Reviewed-by: Aneesh Kumar K.V > --- > hw/9pfs/virtio-9p-handle.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/9pfs/virtio-9p-handle.c b/hw/9pfs/virtio-9p-handle.c > index fe8e0ed19dcc..ed8c126e1d6c 100644 > --- a/hw/9pfs/virtio-9p-handle.c > +++ b/hw/9pfs/virtio-9p-handle.c > @@ -582,6 +582,7 @@ static int handle_unlinkat(FsContext *ctx, V9fsPath *dir, > static int handle_ioc_getversion(FsContext *ctx, V9fsPath *path, > mode_t st_mode, uint64_t *st_gen) > { > +#ifdef FS_IOC_GETVERSION > int err; > V9fsFidOpenState fid_open; > > @@ -599,6 +600,10 @@ static int handle_ioc_getversion(FsContext *ctx, V9fsPath *path, > err = ioctl(fid_open.fd, FS_IOC_GETVERSION, st_gen); > handle_close(ctx, &fid_open); > return err; > +#else > + errno = ENOTTY; > + return -1; > +#endif > } > > static int handle_init(FsContext *ctx) > -- > 1.8.5.2