From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33550)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1VCY62-00089v-Ed
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 12:51:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1VCY5v-0002Cq-4l
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 12:50:54 -0400
Received: from mail-ob0-f181.google.com ([209.85.214.181]:44771)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1VCY5u-0002Cj-WF
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 12:50:47 -0400
Received: by mail-ob0-f181.google.com with SMTP id dn14so3953197obc.26
	for <qemu-devel@nongnu.org>; Thu, 22 Aug 2013 09:50:46 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <52160770.90908@redhat.com>
References: <1377103396-24307-1-git-send-email-pbonzini@redhat.com>
	<1377103396-24307-4-git-send-email-pbonzini@redhat.com>
	<20130821170120.GA12305@redhat.com> <5214F273.9060806@redhat.com>
	<20130821170707.GA12410@redhat.com>
	<5214F38D.2020004@redhat.com> <52160770.90908@redhat.com>
Date: Thu, 22 Aug 2013 11:50:43 -0500
Message-ID: <87k3jdsm8s.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 3/3] pvpanic: rename to isa-pvpanic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, hutao@cn.fujitsu.com, "Michael S. Tsirkin" <mst@redhat.com>, armbru@redhat.com, qemu-devel@nongnu.org, rhod@redhat.com, kraxel@redhat.com, lcapitulino@redhat.com, afaerber@suse.de

Laszlo Ersek <lersek@redhat.com> writes:

> On 08/21/13 19:06, Paolo Bonzini wrote:
>> Il 21/08/2013 19:07, Michael S. Tsirkin ha scritto:
>
>>> NACK
>> 
>> You know that a single developer's NACK counts nothing (it can be you,
>> it can be me), don't you?
>
> going meta...
>
> What's this?
>
> All I know (... I think I know) about patch acceptance is that Anthony
> prefers to have at least one R-b. As far as I've seen this is not a hard
> requirement (for example, maintainers sometimes send unreviewed patches
> in a pull request, and on occasion they are merged).

I look very poorly on anyone nacking anything.  I value constructive
feedback.

Nacking does not add any value to the conversation.  I admire the fact
that we've been able to maintain a very high level of conversation over
the years on qemu-devel and throwing around nacks just lowers the
overall tone.

If you can't think of anything better to say than NACK, don't even
bother sending the email in the first place.

Regards,

Anthony Liguori

>
> No words have been spent on NAKs yet (... since my subscription, that
> is). Is this stuff formalized somewhere?
>
> Sorry for wasting time...
>
> Thanks,
> Laszlo