From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mohan@in.ibm.com>) id 1Uubeh-0005Ss-08
	for qemu-devel@nongnu.org; Thu, 04 Jul 2013 01:00:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mohan@in.ibm.com>) id 1Uubef-00056e-6t
	for qemu-devel@nongnu.org; Thu, 04 Jul 2013 01:00:30 -0400
Received: from e23smtp03.au.ibm.com ([202.81.31.145]:39047)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mohan@in.ibm.com>) id 1Uubee-00055B-IP
	for qemu-devel@nongnu.org; Thu, 04 Jul 2013 01:00:29 -0400
Received: from /spool/local
	by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mohan@in.ibm.com>;
	Thu, 4 Jul 2013 14:50:38 +1000
Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21])
	by d23dlp02.au.ibm.com (Postfix) with ESMTP id DC52C2BB006E
	for <qemu-devel@nongnu.org>; Thu,  4 Jul 2013 15:00:17 +1000 (EST)
Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])
	by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r644wDvW4063628
	for <qemu-devel@nongnu.org>; Thu, 4 Jul 2013 14:59:09 +1000
Received: from d23av04.au.ibm.com (loopback [127.0.0.1])
	by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r644slgr026155
	for <qemu-devel@nongnu.org>; Thu, 4 Jul 2013 14:54:48 +1000
From: "M. Mohan Kumar" <mohan@in.ibm.com>
In-Reply-To: <1371376960-18192-1-git-send-email-sw@weilnetz.de>
References: <1371376960-18192-1-git-send-email-sw@weilnetz.de>
Date: Thu, 04 Jul 2013 10:24:44 +0530
Message-ID: <87k3l6c4bv.fsf@in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Stefan Weil <sw@weilnetz.de> writes:

> This leak was reported by cppcheck.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Reviewed-by: M. Mohan Kumar <mohan@in.ibm.com>
> ---
>  fsdev/qemu-fsdev.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
> index 6eaf36d..ccfec13 100644
> --- a/fsdev/qemu-fsdev.c
> +++ b/fsdev/qemu-fsdev.c
> @@ -76,6 +76,8 @@ int qemu_fsdev_add(QemuOpts *opts)
>
>      if (fsle->fse.ops->parse_opts) {
>          if (fsle->fse.ops->parse_opts(opts, &fsle->fse)) {
> +            g_free(fsle->fse.fsdev_id);
> +            g_free(fsle);
>              return -1;
>          }
>      }
> -- 
> 1.7.10.4