From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnUJ5-0004SD-72 for qemu-devel@nongnu.org; Fri, 14 Jun 2013 09:44:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnUJ3-0007QE-HM for qemu-devel@nongnu.org; Fri, 14 Jun 2013 09:44:47 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:45020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnUJ3-0007Q7-Az for qemu-devel@nongnu.org; Fri, 14 Jun 2013 09:44:45 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 14 Jun 2013 07:44:44 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 1DC4C3E40030 for ; Fri, 14 Jun 2013 07:44:23 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5EDiZ3c033978 for ; Fri, 14 Jun 2013 07:44:35 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5EDiVhk007473 for ; Fri, 14 Jun 2013 07:44:31 -0600 From: Anthony Liguori In-Reply-To: <1371208516-7857-8-git-send-email-armbru@redhat.com> References: <1371208516-7857-1-git-send-email-armbru@redhat.com> <1371208516-7857-8-git-send-email-armbru@redhat.com> Date: Fri, 14 Jun 2013 08:44:22 -0500 Message-ID: <87k3lwg62x.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v3 07/16] qtest: Don't reset on qtest chardev connect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, alex.williamson@redhat.com, afaerber@suse.de, aviksil@linux.vnet.ibm.com Markus Armbruster writes: > libqtest's qtest_init() connecting to the qtest socket triggers reset. > This was coded in the hope we could use the same QEMU process for > multiple tests that way. Never used. Injects an extra reset even > when it's not used, and that can mess up tests such as the one of > -boot once I'm about to add. Drop it. > > Signed-off-by: Markus Armbruster We could always add a reset qtest command. Probably makes more sense really. Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > qtest.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/qtest.c b/qtest.c > index 07a9612..74f1842 100644 > --- a/qtest.c > +++ b/qtest.c > @@ -472,7 +472,12 @@ static void qtest_event(void *opaque, int event) > > switch (event) { > case CHR_EVENT_OPENED: > - qemu_system_reset(false); > + /* > + * We used to call qemu_system_reset() here, hoping we could > + * use the same process for multiple tests that way. Never > + * used. Injects an extra reset even when it's not used, and > + * that can mess up tests, e.g. -boot once. > + */ > for (i = 0; i < ARRAY_SIZE(irq_levels); i++) { > irq_levels[i] = 0; > } > -- > 1.7.11.7