From: Anthony Liguori <aliguori@us.ibm.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: lagarcia@br.ibm.com, Lei Li <lilei@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Support for VNC LED state extension proposal
Date: Mon, 22 Apr 2013 14:32:21 -0500 [thread overview]
Message-ID: <87k3nul5tm.fsf@codemonkey.ws> (raw)
In-Reply-To: <516CF39B.3060904@redhat.com>
Gerd Hoffmann <kraxel@redhat.com> writes:
> Hi,
>
>>> What is your vnc client? Does it support VNC_ENCODING_EXT_KEY_EVENT?
>>
>> It's uses gvnc as a protocol library and renders via fbdev. It reads
>> keyboard events by putting /dev/tty into mediumraw mode and uses ext key
>> events exclusively. It has no knowledge of the guest keymap.
>
> Neat. URL?
We haven't published yet but I keep meaning too... It's really quite simple.
> Does the linux kernel keep track of {caps,num}lock state (+leds) with
> the keyboard in mediumraw mode?
Nope.
> Or does it expect the userspace app set the led state then?
Yup.
> No UI client (neither vnc nor spice) knows the guest keymap btw.
Well, they do actually.
gtk-vnc has key modifier tracking code. I assume gtk-spice does too.
This code looks at the GdkEventKey::keysym which has gone through the
host keymap. The assumption is that the host keymap == the guest keymap
at least as far as modifiers are concerned.
Take a look at key_event in vncdisplay.c in gtk-vnc.
>> I believe VMware already has a VNC extension for passing LED state
>> changes and I think having an open extension for this is a Good Thing.
>> It's a pretty obvious missing piece in the VNC protocol.
>
> Anyone tried to bug vmware to open the specs for the existing
> extension?
I have in the past but that was many years ago at this point.
Regards,
Anthony Liguori
>
> cheers,
> Gerd
prev parent reply other threads:[~2013-04-22 19:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 13:07 [Qemu-devel] Support for VNC LED state extension proposal Lei Li
2013-04-15 12:40 ` Gerd Hoffmann
2013-04-15 14:41 ` Anthony Liguori
2013-04-15 15:38 ` Gerd Hoffmann
2013-04-15 16:23 ` Anthony Liguori
2013-04-16 6:45 ` Gerd Hoffmann
2013-04-22 19:32 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3nul5tm.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=lagarcia@br.ibm.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).