From: Anthony Liguori <aliguori@us.ibm.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/7] i440fx-test: add test to compare default register values
Date: Tue, 16 Apr 2013 13:13:53 -0500 [thread overview]
Message-ID: <87k3o2e42m.fsf@codemonkey.ws> (raw)
In-Reply-To: <516D7553.4030505@redhat.com>
Eric Blake <eblake@redhat.com> writes:
> On 04/16/2013 09:56 AM, Eric Blake wrote:
>> On 04/16/2013 08:45 AM, Anthony Liguori wrote:
>>> This test compares all of the default register values against the
>>> spec. It turns out we deviate in quite a few places. These
>>> places are really only visible to the BIOS though which is why
>>> this hasn't created any problems.
>>>
>>> The deviation actually happens in the core PCI layer so I suspect
>>> it's not a simple fix if we really care to fix it. For now, just
>>>
>>
>> Conclusion of sentence?
>
> Probably a case of your wording being similar to '#if 0 out the broken
> tests', and 'git commit' eating it because it looked like a comment.
Indeed :-/
Regards,
Anthony Liguori
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
next prev parent reply other threads:[~2013-04-16 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 14:45 [Qemu-devel] [PATCH 0/7] qtest: add libqos Anthony Liguori
2013-04-16 14:45 ` [Qemu-devel] [PATCH 1/7] qtest: don't use system command to avoid double fork Anthony Liguori
2013-04-16 14:45 ` [Qemu-devel] [PATCH 2/7] qtest: add libqos including PCI support Anthony Liguori
2013-04-16 14:45 ` [Qemu-devel] [PATCH 3/7] libqos: add fw_cfg support Anthony Liguori
2013-04-16 14:45 ` [Qemu-devel] [PATCH 4/7] libqos: add malloc support Anthony Liguori
2013-04-16 14:45 ` [Qemu-devel] [PATCH 5/7] i440fx-test: add test to compare default register values Anthony Liguori
2013-04-16 15:56 ` Eric Blake
2013-04-16 15:59 ` Eric Blake
2013-04-16 18:13 ` Anthony Liguori [this message]
2013-04-16 14:45 ` [Qemu-devel] [PATCH 6/7] i440fx-test: add test for PAM functionality Anthony Liguori
2013-04-16 14:45 ` [Qemu-devel] [PATCH 7/7] fw_cfg: add qtest test case Anthony Liguori
2013-04-28 15:29 ` Andreas Färber
2013-04-22 18:35 ` [Qemu-devel] [PATCH 0/7] qtest: add libqos Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3o2e42m.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).