From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USAOW-00067Z-PE for qemu-devel@nongnu.org; Tue, 16 Apr 2013 14:14:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USAOV-00068e-CQ for qemu-devel@nongnu.org; Tue, 16 Apr 2013 14:14:16 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:37636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USAOU-00067t-SB for qemu-devel@nongnu.org; Tue, 16 Apr 2013 14:14:15 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 17 Apr 2013 04:04:51 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id B929F2CE804D for ; Wed, 17 Apr 2013 04:14:00 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3GI0V2A21561496 for ; Wed, 17 Apr 2013 04:00:35 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3GIDvTc031089 for ; Wed, 17 Apr 2013 04:13:57 +1000 From: Anthony Liguori In-Reply-To: <516D7553.4030505@redhat.com> References: <1366123521-4330-1-git-send-email-aliguori@us.ibm.com> <1366123521-4330-6-git-send-email-aliguori@us.ibm.com> <516D7492.7000805@redhat.com> <516D7553.4030505@redhat.com> Date: Tue, 16 Apr 2013 13:13:53 -0500 Message-ID: <87k3o2e42m.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 5/7] i440fx-test: add test to compare default register values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org Eric Blake writes: > On 04/16/2013 09:56 AM, Eric Blake wrote: >> On 04/16/2013 08:45 AM, Anthony Liguori wrote: >>> This test compares all of the default register values against the >>> spec. It turns out we deviate in quite a few places. These >>> places are really only visible to the BIOS though which is why >>> this hasn't created any problems. >>> >>> The deviation actually happens in the core PCI layer so I suspect >>> it's not a simple fix if we really care to fix it. For now, just >>> >> >> Conclusion of sentence? > > Probably a case of your wording being similar to '#if 0 out the broken > tests', and 'git commit' eating it because it looked like a comment. Indeed :-/ Regards, Anthony Liguori > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org