From: Juan Quintela <quintela@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: owasserm@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/6] iov: reorganize iov_send_recv, part 1
Date: Tue, 09 Apr 2013 15:18:58 +0200 [thread overview]
Message-ID: <87k3obdepp.fsf@elfo.elfo> (raw)
In-Reply-To: <1364402192-18169-3-git-send-email-pbonzini@redhat.com> (Paolo Bonzini's message of "Wed, 27 Mar 2013 17:36:28 +0100")
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Once the initial part of the iov is dropped, it is not used anymore.
> Modify iov/iovcnt directly instead of adjusting them with the "si"
> variable.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
I would have preffered that iov was used as const, but as the current
code already modifies it, nothing wrong here.
(coping the iov shouldn't have been such a big problem and we would
remove the need to fix the offsets at the end).
But as said, code is better than what we had.
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2013-04-09 13:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 16:36 [Qemu-devel] [PATCH 0/6] migration: followups for writev patches Paolo Bonzini
2013-03-27 16:36 ` [Qemu-devel] [PATCH 1/6] qemu-file: drop socket_put_buffer Paolo Bonzini
2013-04-09 13:20 ` Juan Quintela
2013-03-27 16:36 ` [Qemu-devel] [PATCH 2/6] iov: reorganize iov_send_recv, part 1 Paolo Bonzini
2013-04-09 13:18 ` Juan Quintela [this message]
2013-03-27 16:36 ` [Qemu-devel] [PATCH 3/6] iov: reorganize iov_send_recv, part 2 Paolo Bonzini
2013-04-09 13:23 ` Juan Quintela
2013-03-27 16:36 ` [Qemu-devel] [PATCH 4/6] iov: reorganize iov_send_recv, part 3 Paolo Bonzini
2013-04-09 13:24 ` Juan Quintela
2013-03-27 16:36 ` [Qemu-devel] [PATCH 5/6] iov: handle partial writes from sendmsg and recvmsg Paolo Bonzini
2013-04-09 13:27 ` Juan Quintela
2013-03-27 16:36 ` [Qemu-devel] [PATCH 6/6] qemu-file: do not use stdio for qemu_fdopen Paolo Bonzini
2013-04-09 13:30 ` Juan Quintela
2013-04-16 21:09 ` Anthony Liguori
2013-04-03 8:08 ` [Qemu-devel] [PATCH 0/6] migration: followups for writev patches Orit Wasserman
2013-04-16 15:41 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2013-04-17 9:46 [Qemu-devel] [PULL (rebased) " Paolo Bonzini
2013-04-17 9:46 ` [Qemu-devel] [PATCH 2/6] iov: reorganize iov_send_recv, part 1 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3obdepp.fsf@elfo.elfo \
--to=quintela@redhat.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).