From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPYRt-0003cu-LE for qemu-devel@nongnu.org; Tue, 09 Apr 2013 09:19:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPYRp-0005mi-1u for qemu-devel@nongnu.org; Tue, 09 Apr 2013 09:18:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPYRo-0005mL-Qj for qemu-devel@nongnu.org; Tue, 09 Apr 2013 09:18:52 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r39DIqrt005001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Apr 2013 09:18:52 -0400 From: Juan Quintela In-Reply-To: <1364402192-18169-3-git-send-email-pbonzini@redhat.com> (Paolo Bonzini's message of "Wed, 27 Mar 2013 17:36:28 +0100") References: <1364402192-18169-1-git-send-email-pbonzini@redhat.com> <1364402192-18169-3-git-send-email-pbonzini@redhat.com> Date: Tue, 09 Apr 2013 15:18:58 +0200 Message-ID: <87k3obdepp.fsf@elfo.elfo> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/6] iov: reorganize iov_send_recv, part 1 Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: owasserm@redhat.com, qemu-devel@nongnu.org Paolo Bonzini wrote: > Once the initial part of the iov is dropped, it is not used anymore. > Modify iov/iovcnt directly instead of adjusting them with the "si" > variable. > > Signed-off-by: Paolo Bonzini I would have preffered that iov was used as const, but as the current code already modifies it, nothing wrong here. (coping the iov shouldn't have been such a big problem and we would remove the need to fix the offsets at the end). But as said, code is better than what we had. Reviewed-by: Juan Quintela