From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNTtP-0003Ll-92 for qemu-devel@nongnu.org; Wed, 03 Apr 2013 16:02:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNTtO-0003vp-81 for qemu-devel@nongnu.org; Wed, 03 Apr 2013 16:02:47 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:41140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNTtN-0003vR-Mv for qemu-devel@nongnu.org; Wed, 03 Apr 2013 16:02:46 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 4 Apr 2013 05:51:43 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id D7E3F357804A for ; Thu, 4 Apr 2013 07:02:40 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r33K25Ru66256990 for ; Thu, 4 Apr 2013 07:02:05 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r33K2AtM004890 for ; Thu, 4 Apr 2013 07:02:10 +1100 From: Anthony Liguori In-Reply-To: <20130321123607.GD32484@redhat.com> References: <1363821803-3380-1-git-send-email-lersek@redhat.com> <1363821803-3380-5-git-send-email-lersek@redhat.com> <514A4A1A.6000105@redhat.com> <514A54E7.4060800@redhat.com> <514AE3F4.9050002@redhat.com> <514AF446.4020004@redhat.com> <20130321123607.GD32484@redhat.com> Date: Wed, 03 Apr 2013 15:01:42 -0500 Message-ID: <87k3ojcrix.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Paolo Bonzini Cc: Laszlo Ersek , kraxel@redhat.com, qemu-devel@nongnu.org "Michael S. Tsirkin" writes: > On Thu, Mar 21, 2013 at 12:51:34PM +0100, Paolo Bonzini wrote: >> Il 21/03/2013 11:41, Laszlo Ersek ha scritto: >> > On 03/21/13 01:31, Laszlo Ersek wrote: >> >> On 03/21/13 00:45, Eric Blake wrote: >> >>> On 03/20/2013 05:23 PM, Laszlo Ersek wrote: >> > >> >>>> +# >> >>>> +# @oem_id: #optional OEM identifier (6 bytes) >> >>> >> >>> s/oem_id/oem-id/ >> >>> >> >>> In general, new QMP interfaces should use '-', not '_'. >> >> >> >> Indeed! I think this warrants a respin. >> > >> > Actually it doesn't, apologies -- I got confused for a minute. Again, >> > since I aim to match the existing option format, I must keep the same >> > spelling. >> >> We should make a list of places where we have mixed conventions, accept >> both, and mass-convert to dash... >> >> Paolo > > Anthony used to nack all mass conversions since they mess up the git > history. Since the movement of headers went in, I gather this position > has been relaxed... It's all about the value-to-cost ratio. Running indent to remove invisible space at the end of lines or sed'ing a way a '_t' just because people like to quote standards too much offers very little value at a high cost. Significantly improving the code layout OTOH adds a lot of value and justifies the impact. Regards, Anthony Liguori > > -- > MST