From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj9iw-0002Uk-Vf for qemu-devel@nongnu.org; Thu, 13 Dec 2012 09:25:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tj9ir-0002JM-2M for qemu-devel@nongnu.org; Thu, 13 Dec 2012 09:25:18 -0500 Received: from mail-ie0-f173.google.com ([209.85.223.173]:47862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj9iq-0002J2-Ue for qemu-devel@nongnu.org; Thu, 13 Dec 2012 09:25:13 -0500 Received: by mail-ie0-f173.google.com with SMTP id e13so3978093iej.4 for ; Thu, 13 Dec 2012 06:25:11 -0800 (PST) From: Anthony Liguori In-Reply-To: <20121213105423.GA6857@amit.redhat.com> References: <87lidm6f7p.fsf@codemonkey.ws> <1354093540-22583-1-git-send-email-alevy@redhat.com> <20121213105423.GA6857@amit.redhat.com> Date: Thu, 13 Dec 2012 08:25:08 -0600 Message-ID: <87k3sm112z.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 0/3] chardev/spice: fix missing spice mouse after migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah , Alon Levy Cc: qemu-devel@nongnu.org, armbru@redhat.com Amit Shah writes: > On (Wed) 28 Nov 2012 [11:05:37], Alon Levy wrote: >> Adds a new char device backend callback to check connectedness, implemented >> for virtio console, and used by spice-char-dev in post migration. >> >> Is using NULL for DeviceState the intention for non device vmstates? It works >> fine in practice. > > Any more opinions / reviews on this series? Anthony? Spice should save its state and not rely on the chardev layer to replay it. I thought this was already pointed out in this thread? Regards, Anthony Liguori > > Amit