From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60954)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TJ44n-0002KY-JG
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 11:08:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TJ44j-0004JG-Iv
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 11:08:01 -0400
Received: from e2.ny.us.ibm.com ([32.97.182.142]:58697)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TJ44j-0004DZ-Ez
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 11:07:57 -0400
Received: from /spool/local
	by e2.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Tue, 2 Oct 2012 11:07:05 -0400
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q92F3QHZ139052
	for <qemu-devel@nongnu.org>; Tue, 2 Oct 2012 11:03:27 -0400
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q92F3QI1009932
	for <qemu-devel@nongnu.org>; Tue, 2 Oct 2012 11:03:26 -0400
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <506A8591.9040306@redhat.com>
References: <1349116911-18550-1-git-send-email-aliguori@us.ibm.com>
	<1349117389.28860.299.camel@bling.home>
	<506A8591.9040306@redhat.com>
Date: Tue, 02 Oct 2012 10:03:19 -0500
Message-ID: <87k3v89ars.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Alex Williamson <alex.williamson@redhat.com>
Cc: Alex Barcelo <abarcelo@ac.upc.edu>, qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> writes:

> Il 01/10/2012 20:49, Alex Williamson ha scritto:
>>> > @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
>>> >      struct vfio_iommu_type1_dma_map map = {
>>> >          .argsz = sizeof(map),
>>> >          .flags = VFIO_DMA_MAP_FLAG_READ,
>>> > -        .vaddr = (__u64)vaddr,
>>> > +        .vaddr = (__u64)(intptr_t)vaddr,
>
> Does this need to be uintptr_t?

I don't think it matters semantically but using uintptr_t can't hurt.

Regards,

Anthony Liguori

>
> Paolo
>
>>> >          .iova = iova,
>>> >          .size = size,
>>> >      };
>> Thanks Anthony
>> 
>> Acked-by: Alex Williamson <alex.williamson@redhat.com>