From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxOee-00022v-MP for qemu-devel@nongnu.org; Fri, 03 Aug 2012 16:39:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxOec-000833-5u for qemu-devel@nongnu.org; Fri, 03 Aug 2012 16:39:28 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:42694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxOec-00082p-1r for qemu-devel@nongnu.org; Fri, 03 Aug 2012 16:39:26 -0400 Received: from /spool/local by e6.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Aug 2012 16:39:22 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 19F4BC9003E for ; Fri, 3 Aug 2012 16:37:24 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q73KbNXF27656210 for ; Fri, 3 Aug 2012 16:37:23 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7428Dhh010198 for ; Fri, 3 Aug 2012 22:08:15 -0400 From: Anthony Liguori In-Reply-To: <501C3120.6080909@reactos.org> References: <1343981180-23817-1-git-send-email-pbonzini@redhat.com> <501C261E.40406@us.ibm.com> <501C2D04.5020205@redhat.com> <501C3120.6080909@reactos.org> Date: Fri, 03 Aug 2012 15:37:17 -0500 Message-ID: <87k3xf3e6a.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/10] SCSI patches for 2012-08-03 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Herv=C3=A9?= Poussineau , Paolo Bonzini Cc: Blue Swirl , qemu-devel@nongnu.org Herv=C3=A9 Poussineau writes: > Paolo Bonzini a =C3=A9crit : >> Il 03/08/2012 21:27, Anthony Liguori ha scritto: >>> On 08/03/2012 03:06 AM, Paolo Bonzini wrote: >>>> Anthony, >>>> >>>> The following changes since commit >>>> 5e3bc7144edd6e4fa2824944e5eb16c28197dd5a: >>>> >>>> Merge remote-tracking branch 'mst/tags/for_anthony' into staging >>>> (2012-07-30 10:00:48 -0500) >>>> >>>> are available in the git repository at: >>>> >>>> >>>> git://github.com/bonzini/qemu.git scsi-next >>>> >>>> for you to fetch changes up to b71760ef6180662cc2dff1f6cf673a53508c59f= 1: >>>> >>>> scsi: add support for ATA_PASSTHROUGH_xx scsi command (2012-08-03 >>>> 10:04:37 +0200) >>>> >>>> The main change here is re-enabling megasas, but there's also Herve's >>>> retro HBA and a couple of random fixes. >>> CC sparc-softmmu/target-sparc/mmu_helper.o >>> CC sparc-softmmu/target-sparc/ldst_helper.o >>> CC sparc-softmmu/target-sparc/int32_helper.o >>> LINK sparc-softmmu/qemu-system-sparc >>> ../libhw64/hw/esp.o: In function `dc390_read_config': >>> /home/anthony/git/qemu/hw/esp.c:1220: undefined reference to >>> `pci_default_read_config' >>> ../libhw64/hw/esp.o: In function `dc390_write_config': >>> /home/anthony/git/qemu/hw/esp.c:1245: undefined reference to >>> `pci_default_write_config' >>> collect2: ld returned 1 exit status >>> make[1]: *** [qemu-system-sparc] Error 1 >>> make: *** [subdir-sparc-softmmu] Error 2 >>> >>> It looks like sparc does link in esp.c but doesn't support pci (at least >>> pci.o). I must admit, it's not obvious to me whether pci.o should be >>> added to the sparc build or whether esp.c needs to be refactored. >>=20 >> I think the latter. >>=20 >> I removed this patch and pushed the rest (commit e4b6526) at the same >> location. Blue/Herve, can you look at esp.c? > > I just sent an email to ML to add stubs for pci_default_read_config and=20 > pci_default_write_config. I compile-tested sparc-softmmu target and it=20 > works now well. Shouldn't Sparc consume pci.o? If Sparc doesn't have PCI, then stubs don't seem like the right answer. If it has PCI, then it ought to use the generic code, no? Regards, Anthony Liguori > > Herv=C3=A9 > > [1]