From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwrDg-0002Os-1P for qemu-devel@nongnu.org; Thu, 02 Aug 2012 04:57:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwrDb-00043l-BR for qemu-devel@nongnu.org; Thu, 02 Aug 2012 04:57:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwrDb-00043Z-3s for qemu-devel@nongnu.org; Thu, 02 Aug 2012 04:57:19 -0400 From: Juan Quintela In-Reply-To: <1343839312-24030-5-git-send-email-pbonzini@redhat.com> (Paolo Bonzini's message of "Wed, 1 Aug 2012 18:41:46 +0200") References: <1343839312-24030-1-git-send-email-pbonzini@redhat.com> <1343839312-24030-5-git-send-email-pbonzini@redhat.com> Date: Thu, 02 Aug 2012 10:56:26 +0200 Message-ID: <87k3xh3c5h.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: yang.z.zhang@intel.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Paolo Bonzini wrote: > Also, for consistency with other occurrences, implement VMSTATE_TIMER > as a special case of VMSTATE_TIMER_V rather than VMSTATE_TIMER_TEST. > > Signed-off-by: Paolo Bonzini > --- > vmstate.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/vmstate.h b/vmstate.h > index 5bd2b76..092f21d 100644 > --- a/vmstate.h > +++ b/vmstate.h > @@ -503,8 +503,11 @@ extern const VMStateInfo vmstate_info_unused_buffer; > #define VMSTATE_TIMER_TEST(_f, _s, _test) \ > VMSTATE_POINTER_TEST(_f, _s, _test, vmstate_info_timer, QEMUTimer *) > > +#define VMSTATE_TIMER_V(_f, _s, _v) \ > + VMSTATE_POINTER(_f, _s, _v, vmstate_info_timer, QEMUTimer *) > + > #define VMSTATE_TIMER(_f, _s) \ > - VMSTATE_TIMER_TEST(_f, _s, NULL) > + VMSTATE_POINTER(_f, _s, 0, vmstate_info_timer, QEMUTimer *) You didn't did it, it should be something like: #define VMSTATE_TIMER(_f, _s) \ - VMSTATE_TIMER_TEST(_f, _s, NULL) + VMSTATE_TIMER_V(_f, _s, 0) > > #define VMSTATE_TIMER_ARRAY(_f, _s, _n) \ > VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer *)