From: Anthony Liguori <aliguori@us.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: libvir-list@redhat.com, Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols
Date: Fri, 27 Jul 2012 10:32:54 -0500 [thread overview]
Message-ID: <87k3xpfcd5.fsf@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA_9Vra0HGG5BjV4EKkvxwGLLaYUOyj1pTLkYwoJqs+5EA@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 27 July 2012 14:37, Anthony Liguori <aliguori@us.ibm.com> wrote:
>> --- a/compiler.h
>> +++ b/compiler.h
>> @@ -45,6 +45,7 @@
>> # define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2)))
>> # define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m)))
>> # endif
>> +#define GCC_WEAK __attribute__((weak))
>> #else
>> #define GCC_ATTR /**/
>> #define GCC_FMT_ATTR(n, m)
>
> The GCC manual says "Weak symbols are supported for ELF targets,
> and also for a.out targets when using the GNU assembler and linker".
> Have you tested this on Windows and MacOSX ?
>
> (Also, no version of the macro in the not-GCC branch of the #if.)
(We don't support any compiler other than GCC).
Not really sure why it is even in a branch.
Regards,
Anthony Liguori
>
> -- PMM
next prev parent reply other threads:[~2012-07-27 15:33 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 13:37 [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need to parse -help output Anthony Liguori
2012-07-27 13:37 ` [Qemu-devel] [PATCH 1/7] qmp: introduce device-list-properties command Anthony Liguori
2012-07-27 16:05 ` Luiz Capitulino
2012-08-10 14:40 ` Anthony Liguori
2012-07-27 13:37 ` [Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable Anthony Liguori
2012-07-27 16:06 ` Luiz Capitulino
2012-08-10 14:40 ` Anthony Liguori
2012-07-27 13:37 ` [Qemu-devel] [PATCH 3/7] qapi: add query-machines command Anthony Liguori
2012-07-27 16:12 ` Luiz Capitulino
2012-08-10 14:41 ` Anthony Liguori
2012-08-10 14:50 ` Luiz Capitulino
2012-08-10 16:06 ` Anthony Liguori
2012-08-10 16:15 ` Luiz Capitulino
2012-07-27 17:25 ` Eric Blake
2012-07-27 18:12 ` Anthony Liguori
2012-07-27 18:28 ` Eric Blake
2012-07-27 13:37 ` [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols Anthony Liguori
2012-07-27 13:50 ` Peter Maydell
2012-07-27 14:27 ` Anthony Liguori
2012-07-27 14:45 ` Peter Maydell
2012-07-27 15:31 ` Anthony Liguori
2012-07-27 19:34 ` Blue Swirl
2012-07-27 20:51 ` Anthony Liguori
2012-07-27 21:04 ` Blue Swirl
2012-07-27 22:40 ` Anthony Liguori
2012-07-28 6:25 ` Markus Armbruster
2012-07-28 8:52 ` Blue Swirl
2012-07-28 8:45 ` Blue Swirl
2012-07-28 6:50 ` Peter Maydell
2012-07-28 8:58 ` Blue Swirl
2012-07-27 15:32 ` Anthony Liguori [this message]
2012-07-27 13:37 ` [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command Anthony Liguori
2012-07-27 14:00 ` Peter Maydell
2012-07-27 15:01 ` Anthony Liguori
2012-07-27 16:19 ` Luiz Capitulino
2012-07-27 18:37 ` Eric Blake
2012-07-27 13:37 ` [Qemu-devel] [PATCH 6/7] target-i386: add implementation of query-cpudefs Anthony Liguori
2012-07-31 15:57 ` Eduardo Habkost
2012-08-10 14:43 ` Anthony Liguori
2012-08-10 15:59 ` Eduardo Habkost
2012-08-10 16:37 ` Anthony Liguori
2012-08-10 16:51 ` Eduardo Habkost
2012-08-10 17:09 ` Anthony Liguori
2012-08-10 17:31 ` Eduardo Habkost
2012-07-27 13:37 ` [Qemu-devel] [PATCH 7/7] target-ppc: " Anthony Liguori
2012-07-27 16:21 ` [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need to parse -help output Luiz Capitulino
2012-07-27 16:37 ` Daniel P. Berrange
-- strict thread matches above, loose matches on Subject: below --
2012-08-10 16:04 [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need (v2) Anthony Liguori
2012-08-10 16:04 ` [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols Anthony Liguori
2012-08-12 21:30 ` Peter Maydell
2012-08-13 13:44 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3xpfcd5.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=libvir-list@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).