From: Fabiano Rosas <farosas@suse.de>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: Arun Menon <armenon@redhat.com>,
peterx@redhat.com, Peter Maydell <peter.maydell@linaro.org>,
Juraj Marcin <jmarcin@redhat.com>
Subject: Re: [PATCH 3/3] migration/cpr: Fix UAF in cpr_exec_cb() when execvp() fails
Date: Tue, 21 Oct 2025 17:49:34 -0300 [thread overview]
Message-ID: <87ldl4t1y9.fsf@suse.de> (raw)
In-Reply-To: <20251021184132.2635958-4-peterx@redhat.com>
Peter Xu <peterx@redhat.com> writes:
> Per reported and analyzed by Peter:
>
> https://lore.kernel.org/r/CAFEAcA82ih8RVCm-u1oxiS0V2K4rV4jMzNb13pAV=e2ivmiDRA@mail.gmail.com
>
> Fix the issue by moving the error_setg_errno() earlier. When at it, clear
> argv variable after freed.
>
> Resolves: Coverity CID 1641397
> Fixes: a3eae205c6 ("migration: cpr-exec mode")
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
prev parent reply other threads:[~2025-10-21 20:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 18:41 [PATCH 0/3] migration: A few fixes on coverity reports Peter Xu
2025-10-21 18:41 ` [PATCH 1/3] migration: Fix error leak in postcopy_ram_listen_thread() Peter Xu
2025-10-21 20:45 ` Fabiano Rosas
2025-10-21 21:20 ` Peter Xu
2025-10-21 18:41 ` [PATCH 2/3] migration/cpr: Fix coverity report in cpr_exec_persist_state() Peter Xu
2025-10-21 20:49 ` Fabiano Rosas
2025-10-21 21:29 ` Peter Xu
2025-10-22 12:24 ` Fabiano Rosas
2025-10-22 12:51 ` Peter Xu
2025-10-22 13:41 ` Fabiano Rosas
2025-10-21 18:41 ` [PATCH 3/3] migration/cpr: Fix UAF in cpr_exec_cb() when execvp() fails Peter Xu
2025-10-21 20:49 ` Fabiano Rosas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldl4t1y9.fsf@suse.de \
--to=farosas@suse.de \
--cc=armenon@redhat.com \
--cc=jmarcin@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).