From: Fabiano Rosas <farosas@suse.de>
To: yong.huang@smartx.com, qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
yong.huang@smartx.com
Subject: Re: [PATCH v4 2/6] migration: Stop CPU throttling conditionally
Date: Thu, 17 Oct 2024 15:02:34 -0300 [thread overview]
Message-ID: <87ldym38w5.fsf@suse.de> (raw)
In-Reply-To: <f0c787080bb9ab0c37952f0ca5bfaa525d5ddd14.1729146786.git.yong.huang@smartx.com>
yong.huang@smartx.com writes:
> From: Hyman Huang <yong.huang@smartx.com>
>
> Since CPU throttling only occurs when auto-converge
> is on, stop it conditionally.
>
> Signed-off-by: Hyman Huang <yong.huang@smartx.com>
> ---
> migration/migration.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 021faee2f3..37a200a177 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3289,7 +3289,9 @@ static MigIterateState migration_iteration_run(MigrationState *s)
> static void migration_iteration_finish(MigrationState *s)
> {
> /* If we enabled cpu throttling for auto-converge, turn it off. */
> - cpu_throttle_stop();
> + if (migrate_auto_converge()) {
> + cpu_throttle_stop();
> + }
>
> bql_lock();
> switch (s->state) {
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2024-10-17 18:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 6:42 [PATCH v4 0/6] migration: auto-converge refinements for huge VM yong.huang
2024-10-17 6:42 ` [PATCH v4 1/6] accel/tcg/icount-common: Remove the reference to the unused header file yong.huang
2024-10-17 17:59 ` Fabiano Rosas
2024-10-17 6:42 ` [PATCH v4 2/6] migration: Stop CPU throttling conditionally yong.huang
2024-10-17 18:02 ` Fabiano Rosas [this message]
2024-10-17 6:42 ` [PATCH v4 3/6] migration: Move cpu-throttole.c from system to migration yong.huang
2024-10-17 18:10 ` Fabiano Rosas
2024-10-17 6:42 ` [PATCH v4 4/6] migration: Remove "rs" parameter in migration_bitmap_sync_precopy yong.huang
2024-10-17 6:42 ` [PATCH v4 5/6] migration: Support periodic RAMBlock dirty bitmap sync yong.huang
2024-10-17 18:57 ` Fabiano Rosas
2024-10-17 19:33 ` Peter Xu
2024-10-17 20:35 ` Fabiano Rosas
2024-10-18 1:55 ` Yong Huang
2024-10-17 6:42 ` [PATCH v4 6/6] tests/migration: Add case for periodic ramblock dirty sync yong.huang
2024-10-17 19:01 ` Fabiano Rosas
2024-10-18 15:08 ` [PATCH v4 0/6] migration: auto-converge refinements for huge VM Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldym38w5.fsf@suse.de \
--to=farosas@suse.de \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=yong.huang@smartx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).