* [PATCH] tests/qtest/migration: Add a check for the availability of the "pc" machine
@ 2024-09-03 11:47 Thomas Huth
2024-09-03 13:03 ` Fabiano Rosas
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2024-09-03 11:47 UTC (permalink / raw)
To: Peter Xu, Fabiano Rosas, qemu-devel
The test_vcpu_dirty_limit is the only test that does not check for the
availability of the machine before starting the test, so it fails when
QEMU has been configured with --without-default-devices. Add a check for
the "pc" machine type to fix it.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/migration-test.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 6c06100d91..8fee18dfbe 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -4026,8 +4026,10 @@ int main(int argc, char **argv)
if (g_str_equal(arch, "x86_64") && has_kvm && kvm_dirty_ring_supported()) {
migration_test_add("/migration/dirty_ring",
test_precopy_unix_dirty_ring);
- migration_test_add("/migration/vcpu_dirty_limit",
- test_vcpu_dirty_limit);
+ if (qtest_has_machine("pc")) {
+ migration_test_add("/migration/vcpu_dirty_limit",
+ test_vcpu_dirty_limit);
+ }
}
ret = g_test_run();
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tests/qtest/migration: Add a check for the availability of the "pc" machine
2024-09-03 11:47 [PATCH] tests/qtest/migration: Add a check for the availability of the "pc" machine Thomas Huth
@ 2024-09-03 13:03 ` Fabiano Rosas
0 siblings, 0 replies; 2+ messages in thread
From: Fabiano Rosas @ 2024-09-03 13:03 UTC (permalink / raw)
To: Thomas Huth, Peter Xu, qemu-devel
Thomas Huth <thuth@redhat.com> writes:
> The test_vcpu_dirty_limit is the only test that does not check for the
> availability of the machine before starting the test, so it fails when
> QEMU has been configured with --without-default-devices. Add a check for
> the "pc" machine type to fix it.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qtest/migration-test.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 6c06100d91..8fee18dfbe 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -4026,8 +4026,10 @@ int main(int argc, char **argv)
> if (g_str_equal(arch, "x86_64") && has_kvm && kvm_dirty_ring_supported()) {
> migration_test_add("/migration/dirty_ring",
> test_precopy_unix_dirty_ring);
> - migration_test_add("/migration/vcpu_dirty_limit",
> - test_vcpu_dirty_limit);
> + if (qtest_has_machine("pc")) {
> + migration_test_add("/migration/vcpu_dirty_limit",
> + test_vcpu_dirty_limit);
> + }
> }
>
> ret = g_test_run();
Reviewed-by: Fabiano Rosas <farosas@suse.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-03 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-03 11:47 [PATCH] tests/qtest/migration: Add a check for the availability of the "pc" machine Thomas Huth
2024-09-03 13:03 ` Fabiano Rosas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).