From: "Alex Bennée" <alex.bennee@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Xingtao Yao" <yaoxt.fnst@fujitsu.com>
Subject: Re: [PATCH v6 1/7] plugins: fix mem callback array size
Date: Tue, 16 Jul 2024 14:53:26 +0100 [thread overview]
Message-ID: <87le21h295.fsf@draig.linaro.org> (raw)
In-Reply-To: <20240706191335.878142-2-pierrick.bouvier@linaro.org> (Pierrick Bouvier's message of "Sat, 6 Jul 2024 12:13:29 -0700")
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
> data was correctly copied, but size of array was not set
> (g_array_sized_new only reserves memory, but does not set size).
>
> As a result, callbacks were not called for code path relying on
> plugin_register_vcpu_mem_cb().
>
> Found when trying to trigger mem access callbacks for atomic
> instructions.
>
> Reviewed-by: Xingtao Yao <yaoxt.fnst@fujitsu.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
I'm queuing this patch to plugins/next as it is a fix.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2024-07-16 13:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 19:13 [PATCH v6 0/7] plugins: access values during a memory read/write Pierrick Bouvier
2024-07-06 19:13 ` [PATCH v6 1/7] plugins: fix mem callback array size Pierrick Bouvier
2024-07-08 9:27 ` Alex Bennée
2024-07-16 13:53 ` Alex Bennée [this message]
2024-07-06 19:13 ` [PATCH v6 2/7] plugins: save value during memory accesses Pierrick Bouvier
2024-07-08 10:55 ` Alex Bennée
2024-07-06 19:13 ` [PATCH v6 3/7] plugins: extend API to get latest memory value accessed Pierrick Bouvier
2024-07-08 10:56 ` Alex Bennée
2024-07-06 19:13 ` [PATCH v6 4/7] tests/tcg: add mechanism to run specific tests with plugins Pierrick Bouvier
2024-07-08 11:00 ` Alex Bennée
2024-07-12 0:24 ` Pierrick Bouvier
2024-07-06 19:13 ` [PATCH v6 5/7] tests/tcg: allow to check output of plugins Pierrick Bouvier
2024-07-08 16:06 ` Alex Bennée
2024-07-12 0:36 ` Pierrick Bouvier
2024-07-06 19:13 ` [PATCH v6 6/7] tests/plugin/mem: add option to print memory accesses Pierrick Bouvier
2024-07-06 19:13 ` [PATCH v6 7/7] tests/tcg/x86_64: add test for plugin memory access Pierrick Bouvier
2024-07-07 18:25 ` Richard Henderson
2024-07-12 0:41 ` Pierrick Bouvier
2024-07-08 19:15 ` Alex Bennée
2024-07-12 0:48 ` Pierrick Bouvier
2024-07-12 14:51 ` Alex Bennée
2024-07-12 17:14 ` Pierrick Bouvier
2024-07-19 1:01 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le21h295.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
--cc=yaoxt.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).