From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C42CC27C79 for ; Mon, 17 Jun 2024 19:42:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJIEb-0004ET-10; Mon, 17 Jun 2024 15:41:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJIEZ-0004Do-KJ for qemu-devel@nongnu.org; Mon, 17 Jun 2024 15:41:43 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJIEY-00049G-1y for qemu-devel@nongnu.org; Mon, 17 Jun 2024 15:41:43 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6C21A21CCB; Mon, 17 Jun 2024 19:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718653300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6nH5xzNlmsycPH+FAWlNd7EnzS94pnrbh6oBTi095Z8=; b=lPKhYM74S095NYsU5AND13HNBSY6BDZ12lrpQJpSa5Xu1KvS8uJ1NSClsREaO+G6kyiUiV boyLkOL+RMOwo6nm4PWXRT6hwf+LHptlPcFcSXBAvulrgB71erxqnRlobuS+QUE5Lk/R6T ID/+i+pwNIQTCJVasUjeBK6o6+rPIyk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718653300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6nH5xzNlmsycPH+FAWlNd7EnzS94pnrbh6oBTi095Z8=; b=CymGMG2KJky459IINbt9ylsg8fgPbWFjOxLa4R3alqZPZ1ZysVyIqHDccdOkF959CfYVM5 cazj86sRzCB2sIBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718653300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6nH5xzNlmsycPH+FAWlNd7EnzS94pnrbh6oBTi095Z8=; b=lPKhYM74S095NYsU5AND13HNBSY6BDZ12lrpQJpSa5Xu1KvS8uJ1NSClsREaO+G6kyiUiV boyLkOL+RMOwo6nm4PWXRT6hwf+LHptlPcFcSXBAvulrgB71erxqnRlobuS+QUE5Lk/R6T ID/+i+pwNIQTCJVasUjeBK6o6+rPIyk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718653300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6nH5xzNlmsycPH+FAWlNd7EnzS94pnrbh6oBTi095Z8=; b=CymGMG2KJky459IINbt9ylsg8fgPbWFjOxLa4R3alqZPZ1ZysVyIqHDccdOkF959CfYVM5 cazj86sRzCB2sIBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EA5B313AAA; Mon, 17 Jun 2024 19:41:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YtysK3ORcGbpMwAAD6G6ig (envelope-from ); Mon, 17 Jun 2024 19:41:39 +0000 From: Fabiano Rosas To: Peter Xu , qemu-devel@nongnu.org Cc: Thomas Huth , Markus Armbruster , Laurent Vivier , Eric Blake , Prasad Pandit , peterx@redhat.com, Jiri Denemark , Bandan Das Subject: Re: [PATCH v2 04/10] migration: Cleanup incoming migration setup state change In-Reply-To: <20240617181534.1425179-5-peterx@redhat.com> References: <20240617181534.1425179-1-peterx@redhat.com> <20240617181534.1425179-5-peterx@redhat.com> Date: Mon, 17 Jun 2024 16:41:37 -0300 Message-ID: <87le33bbm6.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-4.28 / 50.00]; BAYES_HAM(-2.98)[99.90%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[10]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email] Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > Destination QEMU can setup incoming ports for two purposes: either a fresh > new incoming migration, in which QEMU will switch to SETUP for channel > establishment, or a paused postcopy migration, in which QEMU will stay in > POSTCOPY_PAUSED until kicking off the RECOVER phase. > > Now the state machine worked on dest node for the latter, only because > migrate_set_state() implicitly will become a noop if the current state > check failed. It wasn't clear at all. > > Clean it up by providing a helper migration_incoming_state_setup() doing > proper checks over current status. Postcopy-paused will be explicitly > checked now, and then we can bail out for unknown states. > > Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas