From: Fabiano Rosas <farosas@suse.de>
To: peterx@redhat.com, qemu-devel@nongnu.org
Cc: peterx@redhat.com, "Avihai Horon" <avihaih@nvidia.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v2 4/5] migration/multifd: Cleanup outgoing_args in state destroy
Date: Thu, 22 Feb 2024 10:58:30 -0300 [thread overview]
Message-ID: <87le7ca9dl.fsf@suse.de> (raw)
In-Reply-To: <20240222095301.171137-5-peterx@redhat.com>
peterx@redhat.com writes:
> From: Peter Xu <peterx@redhat.com>
>
> outgoing_args is a global cache of socket address to be reused in multifd.
> Freeing the cache in per-channel destructor is more or less a hack. Move
> it to multifd_send_cleanup_state() so it only get checked once. Use a
> small helper to do so because it's internal of socket.c.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2024-02-22 13:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 9:52 [PATCH v2 0/5] migration: cleanup TLS channel referencing peterx
2024-02-22 9:52 ` [PATCH v2 1/5] migration/multifd: Cleanup TLS iochannel referencing peterx
2024-02-22 13:55 ` Fabiano Rosas
2024-02-22 9:52 ` [PATCH v2 2/5] migration/multifd: Drop registered_yank peterx
2024-02-22 9:52 ` [PATCH v2 3/5] migration/multifd: Make multifd_channel_connect() return void peterx
2024-02-22 13:57 ` Fabiano Rosas
2024-02-22 9:53 ` [PATCH v2 4/5] migration/multifd: Cleanup outgoing_args in state destroy peterx
2024-02-22 13:58 ` Fabiano Rosas [this message]
2024-02-22 9:53 ` [PATCH v2 5/5] migration/multifd: Drop unnecessary helper to destroy IOC peterx
2024-02-22 14:01 ` Fabiano Rosas
2024-02-26 3:33 ` [PATCH v2 0/5] migration: cleanup TLS channel referencing Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le7ca9dl.fsf@suse.de \
--to=farosas@suse.de \
--cc=avihaih@nvidia.com \
--cc=berrange@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).