From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39691C5479F for ; Thu, 22 Feb 2024 13:58:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rd9aw-0000WH-5D; Thu, 22 Feb 2024 08:58:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rd9av-0000Vm-18 for qemu-devel@nongnu.org; Thu, 22 Feb 2024 08:58:37 -0500 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rd9at-0000Nj-Hi for qemu-devel@nongnu.org; Thu, 22 Feb 2024 08:58:36 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DA22F222A7; Thu, 22 Feb 2024 13:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708610313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P+JU2lIdq4urHt4pLHmy/iDXOLj/yZ6C0zCavDH6wxM=; b=AM85D81zChqxSuHmqPCL96sB52ZW+rIu5d/YX+CukhUpuJoZ2P9ZDTrSJCjPRFMgmvnQke Pg8cxFMhMx0bkrShKDpeF0sZj/n2fzV89UjxLrf55KvOiIl27Mw6TIgdd1ZgUv2ArGUuc+ L+XHvSsk6BBI1VpDQZImGNPpQcIs6+Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708610313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P+JU2lIdq4urHt4pLHmy/iDXOLj/yZ6C0zCavDH6wxM=; b=WmwWhx1BBy5IeEiV3SVihH82EAF6PmNT9jTyU3283yjnZ76QGFI2CnBPqrgG+X6BFrV6DS fpgdqmVUdMTvx0CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708610313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P+JU2lIdq4urHt4pLHmy/iDXOLj/yZ6C0zCavDH6wxM=; b=AM85D81zChqxSuHmqPCL96sB52ZW+rIu5d/YX+CukhUpuJoZ2P9ZDTrSJCjPRFMgmvnQke Pg8cxFMhMx0bkrShKDpeF0sZj/n2fzV89UjxLrf55KvOiIl27Mw6TIgdd1ZgUv2ArGUuc+ L+XHvSsk6BBI1VpDQZImGNPpQcIs6+Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708610313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P+JU2lIdq4urHt4pLHmy/iDXOLj/yZ6C0zCavDH6wxM=; b=WmwWhx1BBy5IeEiV3SVihH82EAF6PmNT9jTyU3283yjnZ76QGFI2CnBPqrgG+X6BFrV6DS fpgdqmVUdMTvx0CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6313013A8C; Thu, 22 Feb 2024 13:58:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ngHECglT12WKQQAAD6G6ig (envelope-from ); Thu, 22 Feb 2024 13:58:33 +0000 From: Fabiano Rosas To: peterx@redhat.com, qemu-devel@nongnu.org Cc: peterx@redhat.com, Avihai Horon , =?utf-8?Q?Daniel?= =?utf-8?Q?_P_=2E_Berrang=C3=A9?= Subject: Re: [PATCH v2 4/5] migration/multifd: Cleanup outgoing_args in state destroy In-Reply-To: <20240222095301.171137-5-peterx@redhat.com> References: <20240222095301.171137-1-peterx@redhat.com> <20240222095301.171137-5-peterx@redhat.com> Date: Thu, 22 Feb 2024 10:58:30 -0300 Message-ID: <87le7ca9dl.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-3.85 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; BAYES_HAM(-2.55)[97.97%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org peterx@redhat.com writes: > From: Peter Xu > > outgoing_args is a global cache of socket address to be reused in multifd. > Freeing the cache in per-channel destructor is more or less a hack. Move > it to multifd_send_cleanup_state() so it only get checked once. Use a > small helper to do so because it's internal of socket.c. > > Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas