From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12403C48297 for ; Mon, 12 Feb 2024 12:48:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZVjW-0003nq-5n; Mon, 12 Feb 2024 07:48:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZVjU-0003nY-AZ; Mon, 12 Feb 2024 07:48:24 -0500 Received: from ik1-413-38519.vs.sakura.ne.jp ([153.127.30.23] helo=sakura.ysato.name) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZVjS-0000FW-OC; Mon, 12 Feb 2024 07:48:24 -0500 Received: from SIOS1075.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id 169591C00F9; Mon, 12 Feb 2024 21:48:15 +0900 (JST) Date: Mon, 12 Feb 2024 21:48:14 +0900 Message-ID: <87le7phmr5.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Mark Cave-Ayland , Zhao Liu , Paolo Bonzini , qemu-block@nongnu.org, John Snow , qemu-ppc@nongnu.org, Eduardo Habkost , Richard Henderson , Markus Armbruster , Magnus Damm Subject: Re: [PATCH v3 07/11] hw/sh4/r2d: Realize IDE controller before accessing it In-Reply-To: <20240208181245.96617-8-philmd@linaro.org> References: <20240208181245.96617-1-philmd@linaro.org> <20240208181245.96617-8-philmd@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=153.127.30.23; envelope-from=ysato@users.sourceforge.jp; helo=sakura.ysato.name X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.256, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, 09 Feb 2024 03:12:40 +0900, Philippe Mathieu-Daud=E9 wrote: >=20 > We should not wire IRQs on unrealized device. >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 > --- > hw/sh4/r2d.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c > index e9f316a6ce..c73e8f49b8 100644 > --- a/hw/sh4/r2d.c > +++ b/hw/sh4/r2d.c > @@ -285,9 +285,9 @@ static void r2d_init(MachineState *machine) > dinfo =3D drive_get(IF_IDE, 0, 0); > dev =3D qdev_new("mmio-ide"); > busdev =3D SYS_BUS_DEVICE(dev); > - sysbus_connect_irq(busdev, 0, irq[CF_IDE]); > qdev_prop_set_uint32(dev, "shift", 1); > sysbus_realize_and_unref(busdev, &error_fatal); > + sysbus_connect_irq(busdev, 0, irq[CF_IDE]); > sysbus_mmio_map(busdev, 0, 0x14001000); > sysbus_mmio_map(busdev, 1, 0x1400080c); > mmio_ide_init_drives(dev, dinfo, NULL); > --=20 > 2.41.0 >=20 Reviewed-by: Yoshinori Sato --=20 Yosinori Sato