From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D976C05027 for ; Fri, 3 Feb 2023 12:33:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNvEv-0000Q8-Tk; Fri, 03 Feb 2023 07:32:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNvEp-0000P1-Se for qemu-devel@nongnu.org; Fri, 03 Feb 2023 07:32:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNvEo-0001nO-6E for qemu-devel@nongnu.org; Fri, 03 Feb 2023 07:32:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675427537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/xMA3+7OwJ3uRlHKDUK4ZWTzlD+x8u764Xcmu3VgblA=; b=EyGKt+K2i7OPEAoHMYSMLZsCYbkOYbe63qYkYImxyZUG2x2LuxQkNZX4bjVnzPYGfc5ZeT YWNAYaS9O3T1X6YNUW+PuffEIz7w5VKdGmEdMf2JKtbe3vDd42iX4C5X+XMgKYzU9gGxvX UbmwNVCpBGQze5vwmrJOe44tq3oKIqE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-296-JPxkwnzyNyyAWwkLYn_mMQ-1; Fri, 03 Feb 2023 07:32:12 -0500 X-MC-Unique: JPxkwnzyNyyAWwkLYn_mMQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E81323C0257C; Fri, 3 Feb 2023 12:32:11 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 598167AD4; Fri, 3 Feb 2023 12:32:11 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 34CDF21E6A1F; Fri, 3 Feb 2023 13:32:10 +0100 (CET) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Eduardo Habkost , Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" , Marcel Apfelbaum Subject: Re: [PATCH 1/9] hw/i386/sgx: Do not open-code qdev_realize_and_unref() References: <20230203113650.78146-1-philmd@linaro.org> <20230203113650.78146-2-philmd@linaro.org> Date: Fri, 03 Feb 2023 13:32:10 +0100 In-Reply-To: <20230203113650.78146-2-philmd@linaro.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Fri, 3 Feb 2023 12:36:42 +0100") Message-ID: <87lelfc4l1.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/i386/sgx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/i386/sgx.c b/hw/i386/sgx.c > index db004d17a6..5ddc5d7ea2 100644 > --- a/hw/i386/sgx.c > +++ b/hw/i386/sgx.c > @@ -299,7 +299,7 @@ void pc_machine_init_sgx_epc(PCMachineState *pcms) > &sgx_epc->mr); >=20=20 > for (list =3D x86ms->sgx_epc_list; list; list =3D list->next) { > - obj =3D object_new("sgx-epc"); > + obj =3D object_new(TYPE_SGX_EPC); I wonder why this doesn't use qdev_new(). >=20=20 > /* set the memdev link with memory backend */ > object_property_parse(obj, SGX_EPC_MEMDEV_PROP, list->value->mem= dev, > @@ -307,8 +307,7 @@ void pc_machine_init_sgx_epc(PCMachineState *pcms) > /* set the numa node property for sgx epc object */ > object_property_set_uint(obj, SGX_EPC_NUMA_NODE_PROP, list->valu= e->node, > &error_fatal); > - object_property_set_bool(obj, "realized", true, &error_fatal); > - object_unref(obj); > + qdev_realize_and_unref(DEVICE(obj), NULL, &error_fatal); Yes, please! Must have crept in after I converted all realizations. I can see two more: hw/pci/pcie_sriov.c: object_property_set_bool(OBJECT(vf), "realized"= , false, &local_err); linux-user/syscall.c: object_property_set_bool(OBJECT(cpu), "rea= lized", false, NULL); > } >=20=20 > if ((sgx_epc->base + sgx_epc->size) < sgx_epc->base) { Reviewed-by: Markus Armbruster