From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86C97C4332F for ; Sat, 3 Dec 2022 09:21:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1Ohy-0004Cp-Ty; Sat, 03 Dec 2022 04:21:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1Ohw-0004CN-UG for qemu-devel@nongnu.org; Sat, 03 Dec 2022 04:21:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1Ohv-0001Jn-A8 for qemu-devel@nongnu.org; Sat, 03 Dec 2022 04:21:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670059274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8EXo/qA8AeKuZlrVxG4H0iswTUAOlcNXWeuOpb8EeFw=; b=F4zr9SlxanKFc9g8wx11jt6D7YOGF2PYp3XLPCvQxJh4c2GRL+v3vDRxtm28eqnmW/2qyl vanFLn10dVAkVbAMHVnITvzsOWcVH5x4hRS0mak0EnPcxlfIgFgYTI4sTN2O/LDyy4vZSw 60VeanNGro+LnKPtjqbiCAGbDODgeGM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-577-0yfMyq0VPeOfFboTsFc4yw-1; Sat, 03 Dec 2022 04:21:13 -0500 X-MC-Unique: 0yfMyq0VPeOfFboTsFc4yw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EFF28894E83; Sat, 3 Dec 2022 09:21:12 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B21172028E96; Sat, 3 Dec 2022 09:21:12 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9799921E6921; Sat, 3 Dec 2022 10:21:09 +0100 (CET) From: Markus Armbruster To: huangy81@chinatelecom.cn Cc: qemu-devel , Peter Xu , "Dr. David Alan Gilbert" , Paolo Bonzini , Laurent Vivier , Eric Blake , Juan Quintela , Thomas Huth , Peter Maydell , Richard Henderson Subject: Re: [PATCH v2 05/11] qapi/migration: Introduce vcpu-dirty-limit parameters References: <3fe7b2324c350b65f2a6fe6e4c585e9de5402e0c.1669047366.git.huangy81@chinatelecom.cn> <87sfhwonn6.fsf@pond.sub.org> Date: Sat, 03 Dec 2022 10:21:09 +0100 In-Reply-To: <87sfhwonn6.fsf@pond.sub.org> (Markus Armbruster's message of "Sat, 03 Dec 2022 10:13:49 +0100") Message-ID: <87lenoonay.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Markus Armbruster writes: > huangy81@chinatelecom.cn writes: > >> From: Hyman Huang(=E9=BB=84=E5=8B=87) >> >> Introduce "vcpu-dirty-limit" migration parameter used >> to limit dirty page rate during live migration. >> >> "vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are >> two dirty-limit-related migration parameters, which can >> be set before and during live migration by qmp >> migrate-set-parameters. >> >> This two parameters are used to help implement the dirty >> page rate limit algo of migration. >> >> Signed-off-by: Hyman Huang(=E9=BB=84=E5=8B=87) > > Could you explain briefly why x-vcpu-dirty-limit-period is experimental, > and vcpu-dirty-limit is not? Prior discussion under "[PATCH v1 3/8] migration: Introduce dirty-limit capability". I'm not asking you to explain all over again, I'm asking you to try to work rationale into the commit message.