qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org, Serge Guelton <sguelton@redhat.com>
Subject: Re: Portable inline asm to get address of TLS variable
Date: Wed, 16 Feb 2022 19:13:05 +0100	[thread overview]
Message-ID: <87leyaznm6.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <Yg04Y05ccrbFVmG/@stefanha-x1.localdomain> (Stefan Hajnoczi's message of "Wed, 16 Feb 2022 17:46:11 +0000")

* Stefan Hajnoczi:

> I've been trying to make the inline asm that gets the address of a TLS
> variable for QEMU coroutines pass QEMU's GitLab CI.
> https://gitlab.com/stefanha/qemu/-/blob/coroutine-tls-fix/include/qemu/coroutine-tls.h#L89
>
> The code isn't -fPIC-friendly (R_X86_64_TPOFF32 relocations aren't
> allowed in -fPIC shared libraries) so builds fail with ./configure
> --enable-modules. While I was tackling this I stumbled on this:
>
>   void *dst_ptr;
>   asm volatile("" : "=r"(dst_ptr) : "0"(&tls_var))
>
> What's nice about it:
> - It's portable, there are no arch-specific assembly instructions.
> - It works for both -fPIC and non-PIC.
>
> However, I wonder if the compiler might reuse a register that already
> contains the address. Then we'd have the coroutine problem again when
> qemu_coroutine_yield() is called between the earlier address calculation
> and the asm volatile statement.
>
> Thoughts?

Sorry, I don't see why this isn't equivalent to a plain &tls_var.
What exactly are you trying to achieve?

Thanks,
Florian



  reply	other threads:[~2022-02-16 18:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16 17:46 Portable inline asm to get address of TLS variable Stefan Hajnoczi
2022-02-16 18:13 ` Florian Weimer [this message]
2022-02-16 20:28   ` Stefan Hajnoczi
2022-02-16 20:33     ` Stefan Hajnoczi
2022-02-16 20:46       ` Florian Weimer
2022-02-17  9:30         ` Stefan Hajnoczi
2022-02-16 20:40     ` Florian Weimer
2022-02-17  9:28       ` Stefan Hajnoczi
2022-02-17 11:40         ` Paolo Bonzini
2022-02-17 15:02           ` Serge Guelton
2022-02-17 15:11             ` Stefan Hajnoczi
2022-02-17 15:51             ` Paolo Bonzini
2022-02-17 14:59         ` Serge Guelton
2022-03-01 11:54         ` Florian Weimer
2022-03-01 13:39           ` Stefan Hajnoczi
2022-04-19 11:32             ` Florian Weimer
2022-04-19 18:38               ` Thomas Rodgers
2022-04-20 14:12               ` Stefan Hajnoczi
2022-02-16 22:28 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87leyaznm6.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sguelton@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).