From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD318C433E0 for ; Wed, 3 Feb 2021 13:14:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FEE264F9A for ; Wed, 3 Feb 2021 13:14:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FEE264F9A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7Hyp-0002Lk-VI for qemu-devel@archiver.kernel.org; Wed, 03 Feb 2021 08:13:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7Hx2-0001V5-UR for qemu-devel@nongnu.org; Wed, 03 Feb 2021 08:12:11 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:37233) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7Hwz-0001Dw-Uc for qemu-devel@nongnu.org; Wed, 03 Feb 2021 08:12:08 -0500 Received: by mail-wm1-x32a.google.com with SMTP id m1so5183637wml.2 for ; Wed, 03 Feb 2021 05:12:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=LL735gNFGfB7GUsHjVgynTjMwKSxqil0hGrfmu2dE30=; b=UOVKN7QfE115KRxsgSjR2Uxqexuq1lu9w7jWckGnhHZTqcQFimCrktHKSzne3dOq6G 3v+ESF8BPL3oVqaUFH1BC3lN3IKPkKWenehSi+OayWShUo2Z4GrRHdU8i9eHFAfg+Df7 UqlIxxczLpqJvln4R60ZkRxeuST32xQQ6Nu8tiMUnc2Y+oeE7kg21bURbN4T5sW74yqX ZyQVFbOTrcQfSLooqXnxYMq0eGm8KsuhKYmCKhC/NXws/nqlWnaewSmv5PSFExJa791a pGbz5XUAgt/SwMVWTq4CepYoC0jXzy8MF0IfQGA+h5KCCM9FlBYUrUgPJQ5M/HugNdse 87Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=LL735gNFGfB7GUsHjVgynTjMwKSxqil0hGrfmu2dE30=; b=I2o9KFkPDp44I21jVvyMzfezIG74TAGCUsysDzul4A0Jl/YEmKnlupV5B5DcXAIBso /43NsYVNS3wxbJEFlvet1AyiCRhBsFTq7aHhB0Kr7Yg9CHWgT2u3WAdd97CCfKtcMcgh dcodEJ29iulIUkubFjLI5u7C8sZqxYXpJeCIF0ab2+eNkqKok+fhVXqMQrxZr+aWPIdv LLFiUYxo+5UIFpLN3Y04ldztm+IL3styzx95l1G4wp+LcOI0JSl49pybT71WRes981Jl brmgIjirRCQ8X/AjAGgMeYCZzxOqXjbj+sNMBeBUk6ubX6+vfiDXLMXw5OT5+K47w5nP C04g== X-Gm-Message-State: AOAM533j6wqIHayA4rd1rOj+GhQsLKe8mJAzaUmcvSd+rkAV+PWgA5w0 LQNNM/p/EM23kY1z4pHcaGqoIw== X-Google-Smtp-Source: ABdhPJzkUvyT6P1UnhK6takoP8iyupA5TQ0zo1+bIAvtO/qnTdrv6xZh6F3HSSIzg9f7rqh5cXOP2A== X-Received: by 2002:a1c:ba44:: with SMTP id k65mr2690623wmf.25.1612357918267; Wed, 03 Feb 2021 05:11:58 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u142sm2865049wmu.3.2021.02.03.05.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 05:11:57 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 675191FF7E; Wed, 3 Feb 2021 13:11:56 +0000 (GMT) References: <20210201100903.17309-1-cfontana@suse.de> <20210201100903.17309-15-cfontana@suse.de> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Claudio Fontana Subject: Re: [PATCH v15 14/23] cpu: move debug_check_watchpoint to tcg_ops Date: Wed, 03 Feb 2021 13:11:51 +0000 In-reply-to: <20210201100903.17309-15-cfontana@suse.de> Message-ID: <87lfc5s3c3.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Eduardo Habkost , Richard Henderson , qemu-devel@nongnu.org, Roman Bolshakov , Alistair Francis , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Claudio Fontana writes: > commit 568496c0c0f1 ("cpu: Add callback to check architectural") and > commit 3826121d9298 ("target-arm: Implement checking of fired") > introduced an ARM-specific hack for cpu_check_watchpoint. > > Make debug_check_watchpoint optional, and move it to tcg_ops. > > Signed-off-by: Claudio Fontana Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e