From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AEFFC433E0 for ; Thu, 14 Jan 2021 13:53:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 372CC23A6C for ; Thu, 14 Jan 2021 13:53:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 372CC23A6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0349-0003o9-9q for qemu-devel@archiver.kernel.org; Thu, 14 Jan 2021 08:53:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l02xj-000533-Az for qemu-devel@nongnu.org; Thu, 14 Jan 2021 08:46:55 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:42750) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l02xh-0001BW-G8 for qemu-devel@nongnu.org; Thu, 14 Jan 2021 08:46:55 -0500 Received: by mail-wr1-x434.google.com with SMTP id m4so5804777wrx.9 for ; Thu, 14 Jan 2021 05:46:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=2j3W696e5MOHC9SR9OOL7/rPmRqgT4sACuZ98lFWd0s=; b=SgEKG+qSHavmbXnKXElb/PCkakT7wgPWl9dOpTKZfs7jVeMsVipGkVdwgvvCcnxgns jGHE4K0xijnv60PBFBS36b/FgyOYALFPuLfWp66qFdYzoxG/Aak6djvPUN3y79QsYbxC yv5/r/RsD5G/06R2DXjh5qUexOS2cJJAEFh8Tujc/oyUMU/ZEfgurKvDV5A3yhdttggl aX5HrpEVQjVSiBfvthIj9O4svrUO1882/pn2eJuRxVb1MwTh5SsDmZy6zA0CSbkiLwAY dwqcWMQlj23hxb08qZoJ9dKxClpufVfeNw3Petre0FJd3u6E6BYEmV95ZyWcakdPdM/0 DoUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=2j3W696e5MOHC9SR9OOL7/rPmRqgT4sACuZ98lFWd0s=; b=O6XRE/c50sWK5ga+TuyZHuX61TbLDYENN76l9zlOH3La1FsfWB306OpCcT6eMrtUd2 2fc2nFJlRx4+tJBgVhF65uWo4HJO+5t20djmmadahJE5TKqOOUdvQR+wV8HgHk8fLL3Y 5E8JYbD3lAKaAIZMXceh6WxvYDxfPKl3xAe6znmASJROwRctuSEuSI+VUD/tcjnoAkmm Bk5ZByG6APLFM9EzDkJY+3qdyRWotM/HWVwDjH5ON23z4zMcXAvxkDAePPl3BT6tYg86 vWtsMDMxT/a4PVth95axm8zOO1RJJICV1mLJC7yYH8J6j13sx7lmbWQmrfikbEyEbgH5 NpSQ== X-Gm-Message-State: AOAM530s1I47STmntN1DkIQ4Qs8OaS7nE1Hltw3nZlPcq17zsHx0XECm myXEL19L53odyiXMKZX4OGsiig== X-Google-Smtp-Source: ABdhPJx3/FxRqSfzgdDhHRDT39CMSpDfzUY7yBAFs5oY04BqzQWm9ZpApIz4XunY6Gf4hUWW3GZhSQ== X-Received: by 2002:adf:dd92:: with SMTP id x18mr8083921wrl.311.1610632011868; Thu, 14 Jan 2021 05:46:51 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id a25sm8341728wmb.25.2021.01.14.05.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 05:46:50 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7C9ED1FF7E; Thu, 14 Jan 2021 13:46:49 +0000 (GMT) References: <87r1mnlr0a.fsf@linaro.org> <20210114141918.5201cc9c@gecko.fritz.box> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Lukas Straub Subject: Re: [PATCH] Fix build with new yank feature by adding stubs Date: Thu, 14 Jan 2021 13:46:17 +0000 In-reply-to: <20210114141918.5201cc9c@gecko.fritz.box> Message-ID: <87lfcvljg6.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Markus Armbruster , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Lukas Straub writes: > Signed-off-by: Lukas Straub Tested-by: Alex Benn=C3=A9e Reviewed-by: Alex Benn=C3=A9e I'm also going to pull this into my testing/next as I need the fix as a prerequisite. > --- > stubs/meson.build | 1 + > stubs/yank.c | 29 +++++++++++++++++++++++++++++ > 2 files changed, 30 insertions(+) > create mode 100644 stubs/yank.c > > diff --git a/stubs/meson.build b/stubs/meson.build > index 80b1d81a31..1a656cd070 100644 > --- a/stubs/meson.build > +++ b/stubs/meson.build > @@ -47,6 +47,7 @@ stub_ss.add(files('vm-stop.c')) > stub_ss.add(files('win32-kbd-hook.c')) > stub_ss.add(files('cpu-synchronize-state.c')) > if have_block > + stub_ss.add(files('yank.c')) > stub_ss.add(files('replay-tools.c')) > endif > if have_system > diff --git a/stubs/yank.c b/stubs/yank.c > new file mode 100644 > index 0000000000..6090416065 > --- /dev/null > +++ b/stubs/yank.c > @@ -0,0 +1,29 @@ > +#include "qemu/osdep.h" > +#include "qemu/yank.h" > + > +bool yank_register_instance(const YankInstance *instance, Error **errp) > +{ > + return true; > +} > + > +void yank_unregister_instance(const YankInstance *instance) > +{ > +} > + > +void yank_register_function(const YankInstance *instance, > + YankFn *func, > + void *opaque) > +{ > +} > + > +void yank_unregister_function(const YankInstance *instance, > + YankFn *func, > + void *opaque) > +{ > +} > + > +void yank_generic_iochannel(void *opaque) > +{ > +} > + > + --=20 Alex Benn=C3=A9e