Re: [PATCH v1 3/6] tests/vm: use console_consume for netbsd

["Alex Bennée" <alex.bennee@linaro.org>]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Hi Alex,
>
> On 11/4/19 6:36 PM, Alex Bennée wrote:
>> From: Gerd Hoffmann <kraxel@redhat.com>
>> Use new helper to read all pending console output,
>> not just a single char.  Unblocks installer boot.
>
> Again, why not use this by default for everything?

I thought that has already got merged via other updates. Will double
check.

>
> Anyway,
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> Message-Id: <20191031085306.28888-4-kraxel@redhat.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>   tests/vm/netbsd | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
>> index 5e04dcd9b16..d1bccccfd01 100755
>> --- a/tests/vm/netbsd
>> +++ b/tests/vm/netbsd
>> @@ -93,7 +93,7 @@ class NetBSDVM(basevm.BaseVM):
>>           for char in list("5consdev com0\n"):
>>               time.sleep(0.2)
>>               self.console_send(char)
>> -            self.console_wait("")
>> +            self.console_consume()
>>           self.console_wait_send("> ", "boot\n")
>>             self.console_wait_send("Terminal type",
>> "xterm\n")
>>


--
Alex Bennée