From: "Alex Bennée" <alex.bennee@linaro.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Fam Zheng" <fam@euphon.net>
Subject: Re: [Qemu-devel] [PATCH v2] tests/vm: move images to $HOME/.cache/qemu-vm/images
Date: Fri, 25 Jan 2019 06:48:57 +0000 [thread overview]
Message-ID: <87lg39z0yu.fsf@linaro.org> (raw)
In-Reply-To: <20190124115448.30487-1-kraxel@redhat.com>
Gerd Hoffmann <kraxel@redhat.com> writes:
> It's easier to move around the images then, by replacing the
> subdirectory with a symlink. Allows to share the images between
> multiple qemu checkouts for example.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Queued to testing/next, thanks.
> ---
>
> Notes:
> v2: use $HOME/.cache/qemu-vm/images as location
>
> tests/vm/Makefile.include | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
> index a98fb3027f..a58383d263 100644
> --- a/tests/vm/Makefile.include
> +++ b/tests/vm/Makefile.include
> @@ -3,7 +3,8 @@
> .PHONY: vm-build-all vm-clean-all
>
> IMAGES := ubuntu.i386 freebsd netbsd openbsd centos
> -IMAGE_FILES := $(patsubst %, tests/vm/%.img, $(IMAGES))
> +IMAGES_DIR := $(HOME)/.cache/qemu-vm/images
> +IMAGE_FILES := $(patsubst %, $(IMAGES_DIR)/%.img, $(IMAGES))
>
> .PRECIOUS: $(IMAGE_FILES)
>
> @@ -24,9 +25,10 @@ vm-build-all: $(addprefix vm-build-, $(IMAGES))
> vm-clean-all:
> rm -f $(IMAGE_FILES)
>
> -tests/vm/%.img: $(SRC_PATH)/tests/vm/% \
> - $(SRC_PATH)/tests/vm/basevm.py \
> - $(SRC_PATH)/tests/vm/Makefile.include
> +$(IMAGES_DIR)/%.img: $(SRC_PATH)/tests/vm/% \
> + $(SRC_PATH)/tests/vm/basevm.py \
> + $(SRC_PATH)/tests/vm/Makefile.include
> + @mkdir -p $(IMAGES_DIR)
> $(call quiet-command, \
> $< \
> $(if $(V)$(DEBUG), --debug) \
> @@ -37,7 +39,7 @@ tests/vm/%.img: $(SRC_PATH)/tests/vm/% \
>
>
> # Build in VM $(IMAGE)
> -vm-build-%: tests/vm/%.img
> +vm-build-%: $(IMAGES_DIR)/%.img
> $(call quiet-command, \
> $(SRC_PATH)/tests/vm/$* \
> $(if $(V)$(DEBUG), --debug) \
--
Alex Bennée
prev parent reply other threads:[~2019-01-25 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 11:54 [Qemu-devel] [PATCH v2] tests/vm: move images to $HOME/.cache/qemu-vm/images Gerd Hoffmann
2019-01-24 16:15 ` Philippe Mathieu-Daudé
2019-01-25 6:48 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg39z0yu.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=kraxel@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).