qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Junpeng.Li <ctlaltlaltc@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu-io read do not dump buffer when in quiet mode
Date: Sat, 21 Apr 2018 12:46:53 +0800	[thread overview]
Message-ID: <87lgdhrwsi.fsf@workstation.novalocal> (raw)
In-Reply-To: <d540f8da-3f0a-71a9-0050-8e8f95153f1c@redhat.com> (Eric Blake's message of "Fri, 20 Apr 2018 14:06:31 -0500")

Eric Blake <eblake@redhat.com> writes:

> On 04/20/2018 11:14 AM, Junpeng.Li wrote:
>> 
>> Hi, everyone. I found a question or maybe a bug during use qemu-io to read
>> a range file and take the params -vq to dump buffer and do not show
>> I/O statistics. I use the params -vq what i want is just dump buffer
>> but do not show I/O statistics, but as the result show it is not.
>> 
>> Like below command, it do not dump buffer to standard output.
>> 
>> qemu-io -r -c "read -vq 0 1024" /tmp/test.qcow2
>> 
>> I saw the source code, when has qflag value it just goto out and do
>> not dump buffer when qflag and vflag has value at the same time.
>> 
>>     if (qflag) {
>>         goto out;
>>     }
>> 
>>     if (vflag) {
>>         dump_buffer(buf, offset, qiov.size);
>>     }
>> 
>> quiet mode here, it mean do not show I/O statistics or mean complete quiet?
>
> You're welcome to provide a patch to make it have saner behavior.  As
> long as running qemu-iotests doesn't break, we are pretty much free to
> refactor qemu-io as it is more a tool for internal testing than for
> external use.
Sorry for my question description and thanks your explanation.

--
BestRegard,
JPL

      reply	other threads:[~2018-04-21  4:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 16:14 [Qemu-devel] qemu-io read do not dump buffer when in quiet mode Junpeng.Li
2018-04-20 19:06 ` Eric Blake
2018-04-21  4:46   ` Junpeng.Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgdhrwsi.fsf@workstation.novalocal \
    --to=ctlaltlaltc@gmail.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).