From: "Alex Bennée" <alex.bennee@linaro.org>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH] scripts/qemu-gdb/timers.py: define encoding in header comment
Date: Fri, 19 Jan 2018 13:56:59 +0000 [thread overview]
Message-ID: <87lggune8k.fsf@linaro.org> (raw)
In-Reply-To: <151629549711.18276.15497684562308683805.stgit@bahia.lan>
Greg Kurz <groug@kaod.org> writes:
> This is required otherwise python complains because of the
> accentuated letter in Alex's last name:
>
> Traceback (most recent call last):
> File "scripts/qemu-gdb.py", line 29, in <module>
> from qemugdb import aio, mtree, coroutine, tcg, timers
> File "scripts/qemugdb/timers.py", line 1
> SyntaxError: Non-ASCII character '\xc3' in file scripts/qemugdb/timers.py
> on line 1, but no encoding declared;
> see http://www.python.org/peps/pep-0263.html for details
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> scripts/qemugdb/timers.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/qemugdb/timers.py b/scripts/qemugdb/timers.py
> index be71a001e333..51ea04b5e2ec 100644
> --- a/scripts/qemugdb/timers.py
> +++ b/scripts/qemugdb/timers.py
> @@ -1,4 +1,5 @@
> #!/usr/bin/python
> +# -*- coding: utf-8 -*-
> # GDB debugging support
> #
> # Copyright 2017 Linaro Ltd
--
Alex Bennée
prev parent reply other threads:[~2018-01-19 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 17:11 [Qemu-devel] [PATCH] scripts/qemu-gdb/timers.py: define encoding in header comment Greg Kurz
2018-01-19 13:56 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lggune8k.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).