From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: peter.maydell@linaro.org, cota@braap.org, qemu-devel@nongnu.org,
"open list:ARM" <qemu-arm@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 4/5] target/arm: use DISAS_JUMP for ISB handling
Date: Tue, 11 Jul 2017 09:27:23 +0100 [thread overview]
Message-ID: <87lgnv9y50.fsf@linaro.org> (raw)
In-Reply-To: <e21159d2-42aa-1b08-5ea9-2f367a8e452f@twiddle.net>
Richard Henderson <rth@twiddle.net> writes:
> On 07/10/2017 09:21 AM, Alex Bennée wrote:
>> - s->is_jmp = DISAS_UPDATE;
>> + gen_a64_set_pc_im(s->pc);
>> + s->is_jmp = DISAS_JUMP;
>
> Better would be gen_goto_tb. The destination is known, so there's no
> need to go through lookup_and_goto_ptr. You still get the icount_decr
> check at the start of the linked TB, which is what you're looking for.
>
> Interesting that a64's gen_goto_tb sets is_jmp, but a32 does not...
Hmm the only caller that is not already in the exit path sets it. Maybe
I should push the s->is_jmp to the a32 gen_goto_tb? I can then do the
same in both.
--
Alex Bennée
next prev parent reply other threads:[~2017-07-11 8:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 19:21 [Qemu-devel] [PATCH v2 0/5] arm: fixes for eret, isb and DISAS_UPDATE handling Alex Bennée
2017-07-10 19:21 ` [Qemu-devel] [PATCH v2 1/5] include/exec/exec-all: document common exit conditions Alex Bennée
2017-07-10 19:21 ` [Qemu-devel] [PATCH v2 2/5] target/arm/translate: make DISAS_UPDATE match declared semantics Alex Bennée
2017-07-10 19:32 ` Richard Henderson
2017-07-10 19:21 ` [Qemu-devel] [PATCH v2 3/5] target/arm/translate.h: expand comment on DISAS_EXIT Alex Bennée
2017-07-10 19:52 ` Richard Henderson
2017-07-10 19:21 ` [Qemu-devel] [PATCH v2 4/5] target/arm: use DISAS_JUMP for ISB handling Alex Bennée
2017-07-10 19:43 ` Richard Henderson
2017-07-11 8:27 ` Alex Bennée [this message]
2017-07-11 17:08 ` Richard Henderson
2017-07-10 19:21 ` [Qemu-devel] [PATCH v2 5/5] target/arm: use DISAS_EXIT for eret handling Alex Bennée
2017-07-10 19:58 ` Richard Henderson
2017-07-10 22:07 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgnv9y50.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).