From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDS8z-0002oP-SC for qemu-devel@nongnu.org; Wed, 24 May 2017 04:59:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDS8x-0000Wc-C1 for qemu-devel@nongnu.org; Wed, 24 May 2017 04:59:49 -0400 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:37662) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDS8x-0000WA-2q for qemu-devel@nongnu.org; Wed, 24 May 2017 04:59:47 -0400 Received: by mail-wm0-x229.google.com with SMTP id d127so59489109wmf.0 for ; Wed, 24 May 2017 01:59:46 -0700 (PDT) References: <20170521032956.27446-1-f4bug@amsat.org> <20170521032956.27446-16-f4bug@amsat.org> <87zie52dcs.fsf@linaro.org> <00181409-39e7-0d0d-e936-1ee0824f2cc5@amsat.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <00181409-39e7-0d0d-e936-1ee0824f2cc5@amsat.org> Date: Wed, 24 May 2017 09:59:51 +0100 Message-ID: <87lgpm3a0o.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 15/24] docker: add powerpc build target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Fam Zheng , David Gibson , Alexander Graf , qemu-ppc@nongnu.org, Aurelien Jarno , Riku Voipio , Vagrant Cascadian , Michael Tokarev Philippe Mathieu-Daudé writes: > Hi Alex, > > On 05/22/2017 11:08 AM, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> tests/docker/Makefile.include | 4 +-- >>> .../docker/dockerfiles/debian-powerpc-cross.docker | 40 ++++++++++++++++++++++ >>> 2 files changed, 42 insertions(+), 2 deletions(-) >>> create mode 100644 tests/docker/dockerfiles/debian-powerpc-cross.docker >>> >>> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include >>> index 111b8090b2..9815976486 100644 >>> --- a/tests/docker/Makefile.include >>> +++ b/tests/docker/Makefile.include >>> @@ -56,11 +56,13 @@ docker-image-%: $(DOCKER_FILES_DIR)/%.docker >>> "BUILD","$*") >>> >>> docker-image-debian-mipsel-cross: EXTRA_FILES:=tests/docker/dockerfiles/debian-apt-fake.sh >>> +docker-image-debian-powerpc-cross: EXTRA_FILES:=tests/docker/dockerfiles/debian-apt-fake.sh >>> >>> # Enforce dependancies for composite images >>> docker-image-debian-armhf-cross: docker-image-debian >>> docker-image-debian-arm64-cross: docker-image-debian >>> docker-image-debian-mipsel-cross: docker-image-debian >>> +docker-image-debian-powerpc-cross: docker-image-debian >>> >>> # Expand all the pre-requistes for each docker image and test combination >>> $(foreach i,$(DOCKER_IMAGES), \ >>> @@ -111,8 +113,6 @@ docker: >>> @echo ' NOUSER Define to disable adding current user to containers passwd.' >>> @echo ' NOCACHE=1 Ignore cache when build images.' >>> @echo ' EXECUTABLE= Include executable in image.' >>> - @echo ' EXTRA_FILES=" [... ]"' >>> - @echo ' Include extra files in image.' >> >> I'm fairly sure you didn't want to do this. > > Ups, good catch :) Rebase mistake. > Are you Ok with those 2 lines back? (I think since it is pretty much a > copy/paste of mipsel Dockerfile). > I'll send fixed and your other r-b after Fam review, thanks! Sure its fine with that fixed: Reviewed-by: Alex Bennée > >> >>> >>> # This rule if for directly running against an arbitrary docker target. >>> # It is called by the expanded docker targets (e.g. make >>> diff --git a/tests/docker/dockerfiles/debian-powerpc-cross.docker b/tests/docker/dockerfiles/debian-powerpc-cross.docker >>> new file mode 100644 >>> index 0000000000..fa2cc7a657 >>> --- /dev/null >>> +++ b/tests/docker/dockerfiles/debian-powerpc-cross.docker >>> @@ -0,0 +1,40 @@ >>> +# >>> +# Docker powerpc cross-compiler target >>> +# >>> +# This docker target builds on the base debian image. >>> +# >>> +FROM qemu:debian >>> +MAINTAINER Philippe Mathieu-Daudé >>> + >>> +# Add the foreign architecture we want and install dependencies >>> +RUN dpkg --add-architecture powerpc >>> +RUN apt-get update >>> +RUN DEBIAN_FRONTEND=noninteractive eatmydata \ >>> + apt-get install -y --no-install-recommends \ >>> + crossbuild-essential-powerpc >>> + >>> +# to fix "following packages have unmet dependencies" ... >>> +ADD debian-apt-fake.sh /usr/local/bin/apt-fake >>> +RUN apt-get install -y --no-install-recommends \ >>> + equivs \ >>> + pkg-config >>> +RUN apt-fake install \ >>> + pkg-config:powerpc=0.28-1.1-fake && \ >>> + ln -s pkg-config /usr/bin/powerpc-linux-gnu-pkg-config >>> +ENV PKG_CONFIG_PATH /usr/lib/powerpc-linux-gnu/pkgconfig >>> +# >>> + >>> +# Specify the cross prefix for this image (see tests/docker/common.rc) >>> +ENV QEMU_CONFIGURE_OPTS --cross-prefix=powerpc-linux-gnu- >>> + >>> +RUN DEBIAN_FRONTEND=noninteractive eatmydata \ >>> + apt-get build-dep -yy -a powerpc qemu >>> +RUN DEBIAN_FRONTEND=noninteractive \ >>> + apt-get install -y --no-install-recommends \ >>> + glusterfs-common:powerpc \ >>> + libbz2-dev:powerpc \ >>> + liblzo2-dev:powerpc \ >>> + libncursesw5-dev:powerpc \ >>> + libnfs-dev:powerpc \ >>> + librdmacm-dev:powerpc \ >>> + libsnappy-dev:powerpc >> >> >> -- >> Alex Bennée >> -- Alex Bennée