qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 2/3] oslib-win32: Change return type of function getpagesize
Date: Mon, 30 Nov 2015 15:07:28 +0100	[thread overview]
Message-ID: <87lh9fmvhb.fsf@emacs.mitica> (raw)
In-Reply-To: <1448862955-22955-3-git-send-email-sw@weilnetz.de> (Stefan Weil's message of "Mon, 30 Nov 2015 06:55:54 +0100")

Stefan Weil <sw@weilnetz.de> wrote:
> getpagesize on Linux returns an int. Fix QEMU's implementation for
> Windows to return an int (instead of size_t), too.
>
> This fixes a compiler warning which was introduced recently
> (commit 093e3c42).
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Reviewed-by: Juan Quintela <quintela@redhat.com>

This makes -Werror + cross mingw64 cross-compiler for win64 work for me.

Thanks, Juan.

  reply	other threads:[~2015-11-30 14:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30  5:55 [Qemu-devel] [PULL 0/3] wxx: Last minute fixes for 2.5 Stefan Weil
2015-11-30  5:55 ` [Qemu-devel] [PULL 1/3] trace/simple: Fix warning and wrong trace file name for MinGW Stefan Weil
2015-11-30  5:55 ` [Qemu-devel] [PULL 2/3] oslib-win32: Change return type of function getpagesize Stefan Weil
2015-11-30 14:07   ` Juan Quintela [this message]
2015-11-30  5:55 ` [Qemu-devel] [PULL 3/3] w32: Use gcc option -mthreads Stefan Weil
2015-11-30 17:08 ` [Qemu-devel] [PULL 0/3] wxx: Last minute fixes for 2.5 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lh9fmvhb.fsf@emacs.mitica \
    --to=quintela@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).