From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35268)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Zwtkj-0006QN-43
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:25:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Zwtkg-0004U8-GY
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:25:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Zwtkg-0004U2-Ay
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:25:30 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <20151112142034.GI2754@work-vm> (David Alan Gilbert's message of
	"Thu, 12 Nov 2015 14:20:35 +0000")
References: <1447165546-27784-1-git-send-email-quintela@redhat.com>
	<1447165546-27784-43-git-send-email-quintela@redhat.com>
	<CAFEAcA__MSk7eThCkirgQ3ppMMVD4M1VHfGGFP2g57dLuiDYcA@mail.gmail.com>
	<20151112120443.GE2754@work-vm>
	<CAFEAcA-8kog_ASyco7pVjLbnAn9gZ2zXNnd_70ps-s6d_V+cVw@mail.gmail.com>
	<20151112122318.GF2754@work-vm>
	<CAFEAcA80SQ1doqnvkev7WxvFyzgdsu3f4=tKhOTaq5s71Y18rg@mail.gmail.com>
	<20151112130831.GG2754@work-vm>
	<CAFEAcA9eUtQWgMc1Y3evQRwQdpGQULmQe4E5DstA0MSce=L4Fg@mail.gmail.com>
	<CAFEAcA-7oAeT0sJn158PZsYQ7hxzum8C+YvDFPEkVqif_RgZkA@mail.gmail.com>
	<20151112142034.GI2754@work-vm>
Date: Thu, 12 Nov 2015 16:25:23 +0100
Message-ID: <87lha3qly4.fsf@emacs.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the
	post-copy queue
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>

"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * Peter Maydell (peter.maydell@linaro.org) wrote:
>> On 12 November 2015 at 13:18, Peter Maydell <peter.maydell@linaro.org> wrote:
>> > On 12 November 2015 at 13:08, Dr. David Alan Gilbert
>> > <dgilbert@redhat.com> wrote:
>> >> OK, can you try a simple migration by hand outside of the test harness;
>> >> just something simple like:
>> >>
>> >> ./bin/qemu-system-x86_64 -M pc -nographic
>> >> (qemu) migrate "exec: cat > /dev/null"
>> >>
>> >> and the same with q35 ?
>> >
>> > (qemu) migrate "exec: cat > /dev/null"
>> > migrate_get_current do init of current_migration 65307
>> > unqueue_page 65307
>> > 0   qemu-system-x86_64                  0x00000001067c01c3 qemu_mutex_lock + 83
>> 
>> This turns out to be because migrate_init() is corrupting the
>> mutex memory when it does "memset(s, 0, sizeof(*s))". Presumably
>> Linux's initialized-mutex is all-zeroes, but OSX's is not.
>
> OK, thanks for finding that; I've just smoke tested the following
> patch and will post it properly after I test it more thoroughly in
> a couple of hours.

I did a patch that was almost identical. It is passing for me virt-test.

Later, Juan.