From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFgtS-0004QQ-4k for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:55:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFgtN-0006RG-BC for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:55:26 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:35116 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFgtN-0006RC-4b for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:55:21 -0400 References: <1407489672-12212-1-git-send-email-zhang.zhanghailiang@huawei.com> <1407489672-12212-9-git-send-email-zhang.zhanghailiang@huawei.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= Date: Fri, 08 Aug 2014 10:51:54 +0100 In-reply-to: <1407489672-12212-9-git-send-email-zhang.zhanghailiang@huawei.com> Message-ID: <87lhqzjofo.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 08/10] tests/bios-tables-test: check the value returned by fopen() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: kwolf@redhat.com, lkurusa@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, riku.voipio@iki.fi, mjt@tls.msk.ru, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, Li Liu , luonengjun@huawei.com, pbonzini@redhat.com, peter.huangpeng@huawei.com, rth@twiddle.net zhanghailiang writes: > The function fopen() may fail, so check its return value. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Liu > --- > tests/bios-tables-test.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 045eb27..6a357c0 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -790,6 +790,8 @@ int main(int argc, char *argv[]) > const char *arch = qtest_get_arch(); > FILE *f = fopen(disk, "w"); > int ret; > + > + g_assert(f != NULL); > fwrite(boot_sector, 1, sizeof boot_sector, f); > fclose(f); Incorrect use of g_assert. An assertion is a test for things that shouldn't happen so in this case it's saying: * this function assumes files will always successfully open Which is not the case. It's quite possible that a fopen will fail and the correct behaviour is to handle the error, not assert out. -- Alex Bennée