From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1Hzd-0008JC-R8 for qemu-devel@nongnu.org; Mon, 22 Jul 2013 11:25:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1HzY-0006gI-Iw for qemu-devel@nongnu.org; Mon, 22 Jul 2013 11:25:45 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:45144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1HzY-0006g6-CR for qemu-devel@nongnu.org; Mon, 22 Jul 2013 11:25:40 -0400 Received: by mail-ie0-f172.google.com with SMTP id 17so3303076iea.3 for ; Mon, 22 Jul 2013 08:25:39 -0700 (PDT) From: Anthony Liguori In-Reply-To: <51ED26AE.4030201@suse.de> References: <1374483382-12141-1-git-send-email-proljc@gmail.com> <1374483382-12141-5-git-send-email-proljc@gmail.com> <51ED0B7A.2010205@suse.de> <51ED14BD.8050406@suse.de> <51ED26AE.4030201@suse.de> Date: Mon, 22 Jul 2013 10:25:35 -0500 Message-ID: <87li4ywr9s.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= , Peter Maydell Cc: Christian Borntraeger , Richard Henderson , Jia Liu , "qemu-devel@nongnu.org" Andreas F=C3=A4rber writes: > Am 22.07.2013 13:34, schrieb Peter Maydell: >> On 22 July 2013 12:17, Andreas F=C3=A4rber wrote: >>> Am 22.07.2013 12:40, schrieb Peter Maydell: >>>> In any case we should be >>>> consistent across target architectures about what we allow. >>> >>> alpha allows both > [...] >>> It didn't have -cpu ? before QOM, so we decided to print the type names >>> there. >>=20 >> Looking at all of the '-cpu help' output, alpha seems to be >> the odd one out here: none of the others list valid CPUs >> with "-$arch-cpu" suffixes. > > Right, because all others had implemented -cpu ? before we introduced > that naming scheme and I tried to keep output compatibility for them. > Focus for alpha was therefore on -cpu foo compatibility only. > > Anthony had clearly stated on a KVM call that using full type names for > future CPU hot-add was the right thing to do and possibly even composite > convenience types like 4core-xeonblabla-x86_64-cpu; how that relates to > -cpu and new targets was never clearly defined though. ;) That's pretty gross, but yes, we should have: qemu -device Xeon-E5-4610,id=3Dsock0 -device Xeon-E5-4610,id=3Dsock1 Which effectively does: qemu -cpu SandyBridge -smp cores=3D6,threads=3D2,sockets=3D2 By today's standards. I think this applies equally well to other architecture. Model hardware more closely. Regards, Anthony Liguori > > For VMSD we decided to deviate for new migratable targets from legacy > CPUs in favor of consistency with devices, for instance. > >>> Stripping -alpha-cpu off typenames would surely be possible. >>=20 >> I think that that would be better in the name of consistency. > >> Also regarding consistency, not all targets react very well >> to being asked for a nonexistent cpu via "-cpu xyzzy": >> alpha and s390x just plough on without an error > > s390x does not have models yet. This will get fixed once we have agreed > on model names and their implementation. > >> lm32 and unicore32 segfault >>=20 >> (some of this may be default board model bugs rather than >> target-* bugs). > > Yeah, for one sh4 board where I noticed it while refactoring I already > applied an error check. I guess cpu_init() / cpu_*_init() is not > NULL-checked in more machines. Not sure if trying invalid arguments > would be applicable for a qtest? > > Andreas > > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg